From nobody Mon Jul  7 20:36:35 2025
X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbbcr59MYz618sn;
	Mon, 07 Jul 2025 20:36:44 +0000 (UTC)
	(envelope-from herbert@gojira.at)
Received: from mail.bsd4all.net (mail.bsd4all.net [IPv6:2a01:4f8:13b:240c::25])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4bbbcr1D0Bz3YPV;
	Mon, 07 Jul 2025 20:36:43 +0000 (UTC)
	(envelope-from herbert@gojira.at)
Authentication-Results: mx1.freebsd.org;
	none
Date: Mon, 7 Jul 2025 22:36:35 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at;
	s=mail202005; t=1751920595;
	bh=jq9onjmCwF3rIg29EN3WTnnijEgtUrqW+Wx2JyeA0uA=;
	h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type;
	b=zdqZ0RZwzo8RMmeMtZlYRgyFvyRMoS8uu5frnnRQUtsStgoKKNQouTpRp98L5+Fag
	 Dq0FM/Gm94XboO9a4V/OVJHF/PYqgEsmiPJKC0Zviangf4VrVNoEa6JyB/OIrwu7h0
	 a7Ln68DmoB2gUYKiibNKXf+3pS6jxt8gYXNHa1YY7e5RWHepdGyJSYY9ZhRFjGS4Yk
	 S1WFsRZ0RiElqwbnemOc1oDPt+4ce7gumWIXQPl7dI7I+NwCiFToFptKanbYTcLXSr
	 e1/ZNJMrfAiP2e15nEODi800pnHzFvzI9na8xx8Q+6kLis88FflNl8uvJW8IbScRPQ
	 D9DCk3GkPzlNA==
From: "Herbert J. Skuhra" <herbert@gojira.at>
To: Dima Panov <fluffy@freebsd.org>
Cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org,
	dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: 7e35117eb07f - main - Makefile: Hook MIT KRB5 into the build
Message-ID: <aGwv06rGlgW8zmJI@mail.bsd4all.net>
References: <202506160251.55G2pwx4063231@gitrepo.freebsd.org>
 <cc9222b0-8745-48cf-988c-4206287a7a7b@FreeBSD.org>
 <20250620073050.7f03f74e@slippy>
 <ea078103-ece6-4f00-af38-ec5688bef7db@FreeBSD.org>
List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main
List-Help: <mailto:dev-commits-src-main+help@freebsd.org>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-main+unsubscribe@freebsd.org>
X-BeenThere: dev-commits-src-main@freebsd.org
Sender: owner-dev-commits-src-main@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea078103-ece6-4f00-af38-ec5688bef7db@FreeBSD.org>
X-Rspamd-Queue-Id: 4bbbcr1D0Bz3YPV
X-Spamd-Bar: ----
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]

On Mon, Jul 07, 2025 at 10:36:31PM +0300, Dima Panov wrote:
> Hello!
> 
> 
> BTW, it looks like symlink for libkadm5clnt.so is broken and produced a bad file
> $ ls -la libkadm5clnt
> lrwxr-xr-x  1 root wheel 13  7 Jul 20:40 libkadm5clnt -> kadm5clnt_mit
> 
> instead of assumed libkadm5clnt.so -> kadm5clnt_mit.so
> 
> 
> Please review:
> 
> diff --git a/krb5/lib/kadm5clnt/Makefile b/krb5/lib/kadm5clnt/Makefile
> index e377f95f5b6e..be09dd3e210e 100644
> --- a/krb5/lib/kadm5clnt/Makefile
> +++ b/krb5/lib/kadm5clnt/Makefile
> @@ -88,7 +88,7 @@ ${CHPASS_UTIL_STRINGS_ERR_C}: ${CHPASS_UTIL_STRINGS_ERR}
>         rm -f et-c-${.PREFIX}.et et-c-${.PREFIX}.c
> 
>  afterinstall:
> -       ${INSTALL_LIBSYMLINK} ${SHLIB} ${DESTDIR}${LIBDIR}/libkadm5clnt
> +       ${INSTALL_LIBSYMLINK} ${SHLIB_NAME} ${DESTDIR}${LIBDIR}/libkadm5clnt.so
> 
>  .include <bsd.lib.mk>

This produces a valid symlink that 'make delete-old' wants to
remove again:

lrwxr-xr-x  1 root wheel     23 Jul  7 22:26 /usr/lib/libkadm5clnt.so ->
libkadm5clnt_mit.so.121

# make delete-old
>>> Removing old files (only deletes safe to delete libs)
remove /usr/lib/libkadm5clnt.so?