From owner-freebsd-current@FreeBSD.ORG  Wed Jan  5 21:31:08 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6AA3816A4CE; Wed,  5 Jan 2005 21:31:08 +0000 (GMT)
Received: from mailgate1b.savvis.net (mailgate1b.savvis.net [216.91.182.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0D66143D1D; Wed,  5 Jan 2005 21:31:08 +0000 (GMT)
	(envelope-from Maksim.Yevmenkin@savvis.net)
Received: from out001.email.savvis.net (out001.apptix.savvis.net
	[216.91.32.44])j05LUZoj013610;	Wed, 5 Jan 2005 15:30:35 -0600
Received: from s228130hz1ew03.apptix-01.savvis.net ([10.146.4.28]) by
	out001.email.savvis.net with Microsoft SMTPSVC(6.0.3790.211);
	Wed, 5 Jan 2005 15:30:33 -0600
Received: from [10.254.186.111] ([66.35.239.94]) by
	s228130hz1ew03.apptix-01.savvis.net with Microsoft SMTPSVC(6.0.3790.211);
	Wed, 5 Jan 2005 15:30:15 -0600
Message-ID: <41DC5C5E.9080706@savvis.net>
Date: Wed, 05 Jan 2005 13:30:06 -0800
From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040822
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Scott Long <scottl@freebsd.org>,
	Julian Elischer <julian@elischer.org>, Roman Kurakin <rik@cronyx.ru>
References: <41DB08B9.6090801@savvis.net> <41DB1310.4060807@cronyx.ru>
	<41DB1700.7060708@savvis.net> <41DB1839.9080104@elischer.org>
	<41DC4FA2.8070609@savvis.net> <41DC5398.8020508@freebsd.org>
	<41DC5561.4090005@savvis.net> <41DC5690.3090205@freebsd.org>
	<41DC598D.50409@savvis.net>
In-Reply-To: <41DC598D.50409@savvis.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 05 Jan 2005 21:30:16.0051 (UTC)
	FILETIME=[BF596C30:01C4F36D]
X-ECS-MailScanner: No virus is found
cc: current@freebsd.org
Subject: Re: netgraph(4) initialization order
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jan 2005 21:31:08 -0000

[...]

>>> how about new attached patch?
>>>
>>
>> Exactly what I had in mind =-)  Have you tested this out to make sure
>>  it fixes the problem cases?
> 
> i'm building kernel now, but i'm almost certain it will fix the problem. 
> the stack trace i got points to ng_newtype() calling ng_findtype() that 
> wants to mtx_lock(ng_typelist_mtx). i'm pretty sure the ng_typelist_mtx 
> mutex was not initialized, that is ngb_mod_event() was never called.
> 
> panic: mtx_lock() of spin mutex (null) @ 
> /usr/src/sys/netgraph/ng_base.c:1189
> 
> no mutex name and ng_typelist_mtx is *not* a spin mutex.
> 
> ng_ubt(4) calls ng_newtype() from its mod_event handler, so i think 
> ng_ubt(4) mod_event handler was called before ngb_mod_event().

built new kernel (with netgraph and ubt compiled in) and rebooted the 
box. no crash. so patch works.

can i commit it?

thanks,
max