Date: Thu, 11 Aug 2016 22:53:03 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Harry Schmalzbauer <freebsd@omnilan.de>, Mark Johnston <markj@freebsd.org> Cc: FreeBSD Stable <freebsd-stable@freebsd.org>, "kib@FreeBSD.org" <kib@FreeBSD.org> Subject: Re: unionfs bugs, a partial patch and some comments [Was: Re: 1-BETA3 Panic: __lockmgr_args: downgrade a recursed lockmgr nfs @ /usr/local/share/deploy-tools/RELENG_11/src/sys/fs/unionfs/union_vnops.c:1905] Message-ID: <YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0@YTOPR01MB0412.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <57A9A6C0.9060609@omnilan.de> References: <57A79E24.8000100@omnilan.de> <YQBPR01MB0401201977AEA8A803F27B23DD1A0@YQBPR01MB0401.CANPRD01.PROD.OUTLOOK.COM> <57A83C78.1070403@omnilan.de> <20160809060213.GA67664@raichu>,<57A9A6C0.9060609@omnilan.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGFycnkgU2NobWFsemJhdWVyIHdyb3RlOg0KQmV6w7xnbGljaCBNYXJrIEpvaG5zdG9uJ3MgTmFj aHJpY2h0IHZvbSAwOS4wOC4yMDE2IDA4OjAyIChsb2NhbHRpbWUpOg0K4oCmDQo+Pg0KPj4gSnVz dCBmb3IgYW55Ym9keSBlbHNlIG5lZWRpbmcgdW5pb25mczoNCj4+IGh0dHBzOi8vcGVvcGxlLmZy ZWVic2Qub3JnL35hdHRpbGlvL3VuaW9uZnNfbWlzc2luZ19pbnNtbnRxdWVfbG9jay5wYXRjaA0K Pj4NCj4+IFRoaXMgcGF0Y2ggc3RpbGwgYXBwbGllcyBhbmQgSSdtIHN1Y2Nlc3NmdWxseSB1c2lu ZyB0aGlzICh1bm1vZGlmaWVkKSB1cA0KPj4gdG8gRnJlZUJTRC0xMC4zIGFuZCBuZXZlciBoYWQg YW55IHBhbmljIGluIGFsbCB0aGVzZSB5ZWFycy4NCj4NCj4gSGF2aW5nIHNwZW50IHNvbWUgdGlt ZSBsb29raW5nIGF0IHVuaW9uZnMsIEknbSBhIGJpdCBza2VwdGljYWwgdGhhdCB0aGlzDQo+IHBh dGNoIHdpbGwgYWRkcmVzcyB0aGUgcGFuaWMgeW91IHJlcG9ydGVkIGVhcmxpZXIsIHRob3VnaCBJ J2QgYmUNCj4gaW50ZXJlc3RlZCB0byBrbm93IGlmIGl0IGRvZXMuDQpbc3R1ZmYgc25pcHBlZCBm b3IgYnJldml0eV0NCkkgdG9vayBhIGxvb2sgYXQgdGhpcy4gKEkga25vdyBub3RoaW5nIGFib3V0 IHVuaW9uZnMsIGJ1dCBhIGxpdHRsZSB3LnIudC4gdGhlIFZGUykuDQpJIGNhbiBjb25maXJtIHRo YXQgdGhpcyBmdW5jdGlvbiAodW5pb25mc19ub2RlZ2V0KCkpIGlzIHdlaXJkIGFuZCBhcHBlYXJz IHRvDQpiZSBicm9rZW4gdG8gbWUuDQoNClRoZSBmdW5jdGlvbiBjYWxscyBpbnNtbnRxdWUoKSBi ZWZvcmUgaXQgaW5pdGlhbGl6ZXMgdGhlIHZub2RlLCB3aGljaCBzZWVtcw0KcmFjZXksIGVzcGVj aWFsbHkgaWYgaXQgaXNuJ3QgTEtfRVhDTFVTSVZFIGxvY2tlZC4NCkFsc28sIGxpbmUjcyAyNzgt MjgxOg0KICAgIGlmICh1cHBlcnZwICE9IE5VTExWUCkNCiAgICAgICAgIHZwLT52X3ZubG9jayA9 IHVwcGVydnAtPnZfdm5sb2NrOw0KICAgIGVsc2UNCiAgICAgICAgIHZwLT52X3ZubG9jayA9IGxv d2VydnAtPnZfdm5sb2NrOw0Kc28geW91ciBwYXRjaCBpc24ndCBsb2NraW5nIHRoZSB2bm9kZSBs b2NrIHRoYXQgaXQgYWN0dWFsbHkgdXNlcy4NCkkgdGhpbmsgdGhlIHZwIGFyZ3VtZW50IHRvIGlu c21udHF1ZSgpIGlzIHJlcXVpcmVkIHRvIGJlIExLX0VYQ0xVU0lWRQ0KbG9ja2VkIG1vc3RseSBz byBvdGhlciB0aHJlYWRzIHdvbid0IGZpZGRsZSB3aXRoIHRoZSB2bm9kZSB1bnRpbCB0aGlzDQpm dW5jdGlvbiBpcyBkb25lIHdpdGggaXQsIGJ1dCBJIGFtIG5vdCBzdXJlPw0KDQpJIHRoaW5rIGEg bW9yZSBjb3JyZWN0IHZlcnNpb24gb2YgdGhpcyAobm90IHNheWluZyBpdCB3b3VsZCBiZSBjb3Jy ZWN0W/CfmIldLA0Kd291bGQgY2FsbCBpbnNtbnRxdWUoKSBsYXRlciBpbiB0aGUgZnVuY3Rpb24s IGFmdGVyIGl0IGhhcyBiZWVuIGluaXRpYWxpemVkLg0KKFRoaXMgbWVhbnMgdGhhdCB0aGUgY2xl YW51cCBpZiBpdCBmYWlscyBpcyBtb3JlIGludm9sdmVkLCBidXQuLi4pDQoNCkkndmUgYXR0YWNo ZWQgYSBwYXRjaCAodW50ZXN0ZWQpIHRoYXQgZG9lcyB0aGlzLiBNYXliZSB5b3UgY291bGQgdHJ5 IGl0Pw0KDQpyaWNrDQpwczogSSd2ZSBjYydkIEtvc3RpaywgaW4gY2FzZSBoZSBoYXMgc29tZSBp bnNpZ2h0IHcuci50LiBob3cgdGhpcyBzaG91bGQgYmUgaGFuZGxlZD8NCg0K --_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_ Content-Type: application/octet-stream; name="unionfs-newvnode.patch" Content-Description: unionfs-newvnode.patch Content-Disposition: attachment; filename="unionfs-newvnode.patch"; size=1549; creation-date="Thu, 11 Aug 2016 22:52:48 GMT"; modification-date="Thu, 11 Aug 2016 22:52:48 GMT" Content-Transfer-Encoding: base64 LS0tIGZzL3VuaW9uZnMvdW5pb25fc3Vici5jLnNhdgkyMDE2LTA4LTExIDE4OjIwOjEwLjU4NTk5 OTAwMCAtMDQwMAorKysgZnMvdW5pb25mcy91bmlvbl9zdWJyLmMJMjAxNi0wOC0xMSAxODo0MDo1 MS4xMTkyMjAwMDAgLTA0MDAKQEAgLTI1NSwxMSArMjU1LDYgQEAgdW5pb25mc19ub2RlZ2V0KHN0 cnVjdCBtb3VudCAqbXAsIHN0cnVjdAogCQlmcmVlKHVucCwgTV9VTklPTkZTTk9ERSk7CiAJCXJl dHVybiAoZXJyb3IpOwogCX0KLQllcnJvciA9IGluc21udHF1ZSh2cCwgbXApOwkvKiBYWFg6IFRv byBlYXJseSBmb3IgbXBzYWZlIGZzICovCi0JaWYgKGVycm9yICE9IDApIHsKLQkJZnJlZSh1bnAs IE1fVU5JT05GU05PREUpOwotCQlyZXR1cm4gKGVycm9yKTsKLQl9CiAJaWYgKGR2cCAhPSBOVUxM VlApCiAJCXZyZWYoZHZwKTsKIAlpZiAodXBwZXJ2cCAhPSBOVUxMVlApCkBAIC0yOTMsNiArMjg4 LDI4IEBAIHVuaW9uZnNfbm9kZWdldChzdHJ1Y3QgbW91bnQgKm1wLCBzdHJ1Y3QKIAkgICAgKGxv d2VydnAgIT0gTlVMTFZQICYmIHVtcC0+dW1fbG93ZXJ2cCA9PSBsb3dlcnZwKSkKIAkJdnAtPnZf dmZsYWcgfD0gVlZfUk9PVDsKIAorCS8qCisJICogTm90IHN1cmUgaWYgTEtfUkVUUlkgaXMgbmVl ZGVkIGhlcmU/CisJICogTm9ybWFsbHksIHRoaXMgd291bGQgYmUgZG9uZSB3aXRoIGEgbG9ja21n cigpIGNhbGwsIGJ1dCBpbgorCSAqIHRoaXMgY2FzZSwgdl92bmxvY2sgaXMgYWN0dWFsbHkgYSB2 bm9kZSBsb2NrIGZvciBlaXRoZXIgdGhlCisJICogdXBwZXJ2cCBvciBsb3dlcnZwLCBzbyBJIHVz ZWQgdGhlIHZuX2xvY2soKSBjYWxsLgorCSAqLworCXZuX2xvY2sodnAsIExLX0VYQ0xVU0lWRSB8 IExLX1JFVFJZKTsKKwllcnJvciA9IGluc21udHF1ZSh2cCwgbXApOworCWlmIChlcnJvciAhPSAw KSB7CisJCWlmIChkdnAgIT0gTlVMTFZQKQorCQkJdnJlbGUoZHZwKTsKKwkJaWYgKHVwcGVydnAg IT0gTlVMTFZQKQorCQkJdnJlbGUodXBwZXJ2cCk7CisJCWlmIChsb3dlcnZwICE9IE5VTExWUCkK KwkJCXZyZWxlKGxvd2VydnApOworCQlmcmVlKHVucC0+dW5faGFzaHRibCwgTV9VTklPTkZTSEFT SCk7CisJCWZyZWUodW5wLT51bl9wYXRoLCBNX1VOSU9ORlNQQVRIKTsKKwkJZnJlZSh1bnAsIE1f VU5JT05GU05PREUpOworCQlyZXR1cm4gKGVycm9yKTsKKwl9CisJVk9QX1VOTE9DSyh2cCwgMCk7 CisKIAlpZiAocGF0aCAhPSBOVUxMICYmIGR2cCAhPSBOVUxMVlAgJiYgdnQgPT0gVkRJUikKIAkJ KnZwcCA9IHVuaW9uZnNfaW5zX2NhY2hlZF92bm9kZSh1bnAsIGR2cCwgcGF0aCk7CiAJaWYgKCgq dnBwKSAhPSBOVUxMVlApIHsKQEAgLTMxNCw2ICszMzEsNyBAQCB1bmlvbmZzX25vZGVnZXQoc3Ry dWN0IG1vdW50ICptcCwgc3RydWN0CiAKIHVuaW9uZnNfbm9kZWdldF9vdXQ6CiAJaWYgKGxrZmxh Z3MgJiBMS19UWVBFX01BU0spCisJCS8qIFNob3VsZCB0aGVyZSBiZSBhIGNoZWNrIGZvciBWSV9E T09NRUQgaGVyZT8gKi8KIAkJdm5fbG9jayh2cCwgbGtmbGFncyB8IExLX1JFVFJZKTsKIAogCXJl dHVybiAoMCk7Cg== --_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0>