From owner-dev-commits-src-main@freebsd.org Wed Jun 30 17:59:47 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7FB68649002; Wed, 30 Jun 2021 17:59:47 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GFTdH2v8tz3JcY; Wed, 30 Jun 2021 17:59:47 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1625075987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b+QamJfr0Fc4bKSp9o0jHh7BaUb/z72LkNinusfxpVQ=; b=x7/bDVzH1GHgK17yNzYJl/IDFZLu4MVvQxm/uRzSFy26uqm7caGZOMilMGvWq2Nbv5NntY txeKymGiEaFZxSkzTIViwVmwErGR6pfd/ymg+dWU5zZh5a2wKyekzOG3YCGcF/CyR8RCoS F21ZBYP2+GxMkY4OccfeDvDT1DWEl7IGSueIb9Pu+smt+3etFY4u6vmskoGIhXC06wJleb 44ZIaoo84pxPkRZotg7wgRyTgS1SPXz9jI+01Zoo+YsPBAOOz7QxgVhTkIgpCAdynqtxAe qKA7xT9q5gqBnTiJn6BLMUnuMpiDB9Pi8QkzZrOVXygJp5OIPlumGbUvmwfY0g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2927A5F79; Wed, 30 Jun 2021 17:59:47 +0000 (UTC) Date: Wed, 30 Jun 2021 17:59:47 +0000 From: Alexey Dokuchaev To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3f197b101f71 - main - release: Remove C-like string comparison operator Message-ID: References: <202106301720.15UHKkUQ079377@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202106301720.15UHKkUQ079377@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1625075987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b+QamJfr0Fc4bKSp9o0jHh7BaUb/z72LkNinusfxpVQ=; b=uzaVvsrnlCqHeGqQx9jsPf/FnmLosXywWOa5ud3ZadVAuIjdy62vF+nZPnApZGLAmUnQVh 3yO/tmLVZrtIv/ANQtA6JtzPM03e1pKQQCNBv6LEW9wKnNelO8o11kOgH9EXJBYFFtW6WY uVhtBhjoqfgEjM0qJDd86M4Q92TejE85nSYqvEuUOj/06Fv1arEShp2fJqVJNfc/6HdNz9 g6Dy6JpUO3hku6k9NWESlOn4dgN9vZu52uNtKw1i/4eESyDQQHsymxUsmIErvgaw3sAhCb 90tkzOt9aJEnXZ6iLmTOzsISxbfbeG/UQ4JxH7XkMI/VR/Z4YfvHeZIJu9DG8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1625075987; a=rsa-sha256; cv=none; b=n3CHS6Hd/qrg2bCFd0fakPfl0epWPivOWI/fGKSqikedEquaN1888XBxtbBE14N7CkDjT5 +e53HEAfx78ZMFWtAnY/VkzvmOKeG8Ss0yODm5Q2LJqXgeNb6yZA0Si8gpH5guIJYDcw22 VyI7cswMKSeL2Fcj9B3Lgg3GNlvd/cRKVYB41CDo85Wv/i1qubgZeZ87BZr9k9nAI4qrHY j4DNb/X0sDlg60N1C1ExQEvTqJfLtf73Eq2gXnc3fOWNOkM4rwe919VZiCKXe/R/Ct7OO2 f0SVeLUWmibV8PSSUeZwM2OncROBaahWeYS39HMFciqVMe4NswvSMceAXBKBAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2021 17:59:47 -0000 On Wed, Jun 30, 2021 at 05:20:46PM +0000, Warner Losh wrote: > commit 3f197b101f71ee4f4949c53bf330f61b43749ce9 > > release: Remove C-like string comparison operator > > Per [(1), i.e. test(1), the string comparison operator should be `=`, > not `==` in sh(1) scripts. > > No functional change. FreeBSD's test accepts `==` as an alias for `=` > for compatibility with gnu test's `==` extension. Nice, thanks, but why didn't you remove those needless quotes around static stings, e.g. "GPT" -> GPT? ./danfe