Date: Fri, 14 Jan 2022 22:07:24 +0100 From: Stefan Esser <se@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: bcaf25a8c804 - main - Fix CONFLICTS entries of multiple ports Message-ID: <cd808651-864a-3f5f-0c0a-6cb4f90df0b9@FreeBSD.org> In-Reply-To: <aecbde9-303d-9bfe-1dfd-f8e67faa68b@pfeifer.com> References: <202201101516.20AFGNau035475@gitrepo.freebsd.org> <aecbde9-303d-9bfe-1dfd-f8e67faa68b@pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------uxEP2USgUcaJ0wwWQqqIBPyY Content-Type: multipart/mixed; boundary="------------YowFdYraELxYHWJWMWq5dhd9"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Message-ID: <cd808651-864a-3f5f-0c0a-6cb4f90df0b9@FreeBSD.org> Subject: Re: git: bcaf25a8c804 - main - Fix CONFLICTS entries of multiple ports References: <202201101516.20AFGNau035475@gitrepo.freebsd.org> <aecbde9-303d-9bfe-1dfd-f8e67faa68b@pfeifer.com> In-Reply-To: <aecbde9-303d-9bfe-1dfd-f8e67faa68b@pfeifer.com> --------------YowFdYraELxYHWJWMWq5dhd9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 14.01.22 um 10:46 schrieb Gerald Pfeifer: > On Mon, 10 Jan 2022, Stefan E=C3=9Fer wrote: >> Where possible, version numbers in conflicts entries have been >> generalized, some times taking advantage of the fact that a port >> cannot conflict with itself (due to logic in bsd.port.mk that >> suppresses the pattern match result in that case). >=20 > Indeed, the "a port cannot conflict with itself" part is one I did > fail to understand in the past, unless you and me chatted a bit. ;-) >=20 > I believe it would be helpful if > https://docs.freebsd.org/en/books/porters-handbook/book/#conflicts > had an explicit note that a package does not conflict with itself. Yes, we had discussed this point before, and I do agree that the description in the handbook is easily mis-understood, leading to unnecessarily complex CONFLICTS entries. There are two reviews that I have prepared to fix the conflicts checks in bsd.port.mk to not ignore conflicts for the same port directory (including all FLAVORs of a port), but only for the same package base name: https://reviews.freebsd.org/D31151 (for all pkg versions) https://reviews.freebsd.org/D32694 (for pkg>=3D1.17.2 only) I have only now noticed that bapt@ has accepted the latter review, but I did not want to commit it until pkg-1.17.2 (released 2021-09-21) can be assumed to be installed on all relevant systems. Since these commits will change the details of CONFLICTS processing, I'll wait with an update of the documentation until either of these reviews has been accepted. But I can prepare a review of the planned documentation change, now ... Regards, STefan --------------YowFdYraELxYHWJWMWq5dhd9-- --------------uxEP2USgUcaJ0wwWQqqIBPyY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmHh5gwFAwAAAAAACgkQR+u171r99UQd XAgAr08CZrdxXCsOHpTW22Jxn8n9LVhldQMikD9UFjn2lSMEMiyDu11SuGZR4lyJM+D6FnM+ju2E ucf03qgXO0z22lpIH2G6VbPLY0H8Q//Rx3rLx83MnyGdGa9n1dIX/bleIycDSjwRCmE8Mkp2cv7Y Z/+hIQbTKqZUmBjahWD57bEm8rG9JqkOpWfIdYQLKc2Cj9iFcUkisesbM3vW5EJmyEC/KgOzd7ln vGIuOIC8JAkQHqDxR9kCLJoEFcazFJaHJWTUH6c2XYRZT5n0K+jh572YiuUYuMTjgD7wVVxUGgyJ dgLKEt9L19AQhR/HYA5Vlp4fJ5YhqBcF3tg8S/Bgxw== =LF6g -----END PGP SIGNATURE----- --------------uxEP2USgUcaJ0wwWQqqIBPyY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cd808651-864a-3f5f-0c0a-6cb4f90df0b9>