From owner-svn-src-head@FreeBSD.ORG Tue Sep 30 09:45:51 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B97A27D2; Tue, 30 Sep 2014 09:45:51 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 40022D1F; Tue, 30 Sep 2014 09:45:50 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s8U9jk0N073575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 30 Sep 2014 13:45:46 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s8U9jkD1073574; Tue, 30 Sep 2014 13:45:46 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 30 Sep 2014 13:45:46 +0400 From: Gleb Smirnoff To: Ryan Stone Subject: Re: svn commit: r272284 - head/usr.bin/systat Message-ID: <20140930094546.GA73266@FreeBSD.org> References: <201409291738.s8THcpxo038996@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201409291738.s8THcpxo038996@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2014 09:45:51 -0000 On Mon, Sep 29, 2014 at 05:38:51PM +0000, Ryan Stone wrote: R> Author: rstone R> Date: Mon Sep 29 17:38:50 2014 R> New Revision: 272284 R> URL: http://svnweb.freebsd.org/changeset/base/272284 R> R> Log: R> Fix integer truncation in affecting systat -ifstat R> R> The "systat -ifstat" command was using a u_int to store byte counters. R> With a 10Gbps or faster interface, this overflows within the default R> 5 second refresh period. Switch to using a uint64_t across the board, R> which matches the size used for all counters as of r263102. R> R> PR: 182448 R> MFC after: 1 week R> Sponsored by: Sandvine Inc Thanks, Ryan. I'm always surprised finding people using systat(1) for anything instead of netstat, top, vmstat and the rest. -- Totus tuus, Glebius.