Date: Fri, 13 Apr 2018 16:41:47 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Matthias Fechner <idefix@fechner.net> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files Message-ID: <CAMHz58RD9rtyqBLV6nsZ2naOvGRiO7PDPAGWZ8Vemnz-g1J6cw@mail.gmail.com> In-Reply-To: <e1a55c7b-1ad1-36c8-ec3d-f806702feed5@fechner.net> References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <e1a55c7b-1ad1-36c8-ec3d-f806702feed5@fechner.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 13, 2018 at 4:01 AM, Matthias Fechner <idefix@fechner.net> wrote: > Dear sunpoet, > > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: > > Log: > > Fix Gemfile for rubygem-default_value_for 3.1.0 update > > > > - Bump PORTREVISION for package change > > > > Modified: > > head/www/gitlab/Makefile > > head/www/gitlab/files/patch-Gemfile > I really enjoy your work and it is totally fine for me, if you upgrade a > gem that you copy the old one and make sure that gitlab uses the old. > (like you did with r467106, thanks a lot for this!) > > But please do not start to patch the Gemfile! > This will break gitlab. Have you tested gitlab with this modification? > (for sure not, I reported exactly that version of default_value_for > upstream and they rolled back the change as it broke gitlab, they broke > 3.0.4 and rolled back the modification with 3.0.5, now you changed > gitlab to use the version that for sure will not work!) > > Please revert this modification and ask me (the maintainer) before you > start to modify the port I maintain. > Thanks a lot that you understand this. > Hi, I think that default_value_for 3.0.4 update is a different case. gitlab wats default_value_for ~> 3.0.0 and it fits the rule. I would like to keep less number of gems with multiple versions in the ports tree. It will sometimes make the dependency tree complex. Therefore, I would not copy the old version unless it's necessary. In this case, the only change between default_value_for 3.0.5 and 3.1.0 is Rails 5.2 support [1]. I don't think it breaks gitlab. Can you please confirm if it really breaks gitlab? If so, I'll revert it as soon as possible. Thanks, sunpoet [1] https://github.com/FooBarWidget/default_value_for/commit/2d1802cf4836eb6dd7= 2f1469378e383e79f83fdf > Gru=C3=9F > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RD9rtyqBLV6nsZ2naOvGRiO7PDPAGWZ8Vemnz-g1J6cw>