From owner-svn-ports-all@FreeBSD.ORG Sat Nov 22 21:56:17 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 85F10D2E; Sat, 22 Nov 2014 21:56:17 +0000 (UTC) Received: from mk-outboundfilter-2.mail.uk.tiscali.com (mk-outboundfilter-2.mail.uk.tiscali.com [212.74.114.38]) by mx1.freebsd.org (Postfix) with ESMTP id 396149C6; Sat, 22 Nov 2014 21:56:16 +0000 (UTC) X-Trace: 141893610/mk-outboundfilter-2.mail.uk.tiscali.com/PIPEX/$ON_NET_AUTH_ACCEPTED/pipex-temporary-group/81.170.82.116/-4.0/crees@physics.org X-SBRS: -4.0 X-RemoteIP: 81.170.82.116 X-IP-MAIL-FROM: crees@physics.org X-SMTP-AUTH: bayofrum@uwclub.net X-MUA: Mozilla/5.0 (Windows NT 6.0; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhMHAJMFcVRRqlJ0PGdsb2JhbABcgw5VWcwhhmoCgQEXAQEBAQEGAQEBATg7hAMBAQQ4HiIBEAsUBAkWBAsJAwIBAgEnChQGDQEFAgEBiEEJzTwBAQEBAQEBAwEBAQEBAQEBARmKcTeFYweETgEEkCWHKIRZhCGGLReBGIQDjC2BRUgwgksBAQE X-IPAS-Result: AhMHAJMFcVRRqlJ0PGdsb2JhbABcgw5VWcwhhmoCgQEXAQEBAQEGAQEBATg7hAMBAQQ4HiIBEAsUBAkWBAsJAwIBAgEnChQGDQEFAgEBiEEJzTwBAQEBAQEBAwEBAQEBAQEBARmKcTeFYweETgEEkCWHKIRZhCGGLReBGIQDjC2BRUgwgksBAQE X-IronPort-AV: E=Sophos;i="5.07,438,1413241200"; d="scan'208";a="141893610" X-IP-Direction: OUT Received: from 81-170-82-116.dynamic.dsl.as9105.com (HELO pegasus.bayofrum.net) ([81.170.82.116]) by smtp.pipex.tiscali.co.uk with ESMTP; 22 Nov 2014 21:56:15 +0000 Received: from [192.168.1.192] (athene.bayofrum.net [192.168.1.192]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id F0D3365B2C; Sat, 22 Nov 2014 21:54:52 +0000 (GMT) Message-ID: <54710781.8050008@physics.org> Date: Sat, 22 Nov 2014 22:00:33 +0000 From: Chris Rees User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Adam Weinberger Subject: Re: svn commit: r373100 - in head: . Mk databases/glom databases/libzdb databases/opendbx databases/pglesslog databases/qt4-pgsql-plugin databases/qt5-sqldrivers-pgsql databases/rubygem-do_postgres dat... References: <201411222040.sAMKe9tk086292@svn.freebsd.org> <48EBC1CA-CB07-47E0-88A3-94B1ED7B31A0@adamw.org> <547103CD.2020309@physics.org> <913FC640-B7AB-4020-A0A0-3B2DA4225DD9@adamw.org> In-Reply-To: <913FC640-B7AB-4020-A0A0-3B2DA4225DD9@adamw.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: F0D3365B2C.A7EF0 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@physics.org X-Spam-Status: No Cc: Chris Rees , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Nov 2014 21:56:17 -0000 On 22/11/2014 21:49, Adam Weinberger wrote: >> On 22 Nov, 2014, at 14:44, Chris Rees wrote: >> >> On 22/11/2014 21:31, Adam Weinberger wrote: >>> On 22 Nov, 2014, at 13:40, Chris Rees wrote: >>>> Author: crees >>>> Date: Sat Nov 22 20:40:08 2014 >>>> New Revision: 373100 >>>> URL: https://svnweb.freebsd.org/changeset/ports/373100 >>>> QAT: https://qat.redports.org/buildarchive/r373100/ >>>> >>>> Log: >>>> Finally retire USE_PGSQL >>>> >>>> + USE_PGSQL=server becomes USES=pgsql and WANT_PGSQL=server >>> USES=perl5 has USE_PERL5, USES=python has USE_PYTHON, USES=openal has USE_OPENAL, USES=fam has USE_FAM. >>> >>> Why is pgsql WANT_ instead of USE_? >> Hm. A couple of reasons really; USE_PGSQL was used before by bsd.database.mk, and with the two coexisting perhaps sharing the variable was not desired; I remember back in December last year when writing this that people weren't keen on separate variables at all, preferring to use arguments to USES. During that discussion, no-one mentioned that WANT_PGSQL wasn't desirable (perhaps it wasn't even discussed). >> >> I could rename it to USE_PGSQL now the code is removed from bsd.database.mk I suppose... but is it necessary? I don't personally think it's a great idea to reuse variables that used to mean something else... > Definitely makes sense not to use USE_PGSQL while the transition is underway. But now that the transition is complete, USE_PGSQL is a NOOP unless USES=pgsql is there, no? So if somebody tried to do USE_PGSQL=yes it wouldn't work, same as it won't work now. > > My suggestion would always be to aim for consistency across the different USES modules, but I can't even begin to guess how much work it took to get the USES=pgsql transition done! Well, I've certainly no objection if you want to grep/sed the ports tree, and I can say that with a pgsql hat on :) I fear that I don't currently have the time to do this step at the moment, because it will probably break something and I definitely don't have the availability to fix it at short notice; this is the end of my free evening for a week. Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.