From owner-freebsd-hackers@FreeBSD.ORG  Fri Jul 18 04:35:35 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B3F1B37B401
	for <hackers@freebsd.org>; Fri, 18 Jul 2003 04:35:35 -0700 (PDT)
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BDFB043FB1
	for <hackers@freebsd.org>; Fri, 18 Jul 2003 04:35:34 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (port757.uc1-esp.isdn-lan.cybercity.dk
	[212.242.98.245])
	by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6IBZPV3024353;
	Fri, 18 Jul 2003 11:35:31 GMT	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6IBZNMu006584;
	Fri, 18 Jul 2003 13:35:24 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Harti Brandt <brandt@fokus.fraunhofer.de>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 18 Jul 2003 13:29:44 +0200."
             <20030718132616.G972@beagle.fokus.fraunhofer.de> 
Date: Fri, 18 Jul 2003 13:35:23 +0200
Message-ID: <6583.1058528123@critter.freebsd.dk>
cc: hackers@freebsd.org
Subject: Re: uma_zalloc() not checking flags 
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2003 11:35:36 -0000

In message <20030718132616.G972@beagle.fokus.fraunhofer.de>, Harti Brandt write
s:
>
>Given that uma_zalloc() has the same flags as malloc(9) shouldn't it check
>these flags like malloc(9) does? I would think we could copy the #ifdef
>INVARIANTS section at the beginning of malloc(9) to uma_zalloc_arg().
>
>I just found a large number of calls in the ATM code that have just
>M_ZERO or even 0 flags.
>
>Anything against this check?

Good point, please implement!

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.