Date: Fri, 12 Oct 2018 15:45:10 -0600 From: Sean Bruno <sbruno@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Tobias Kortkamp <tobik@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files Message-ID: <d5bc5542-3ea2-d7d7-2aba-61acab76a94e@freebsd.org> In-Reply-To: <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj Content-Type: multipart/mixed; boundary="ySa79FfN602GWGEoa0hgx4NbVH9wGYHQU"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Tobias Kortkamp <tobik@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <d5bc5542-3ea2-d7d7-2aba-61acab76a94e@freebsd.org> Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> In-Reply-To: <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> --ySa79FfN602GWGEoa0hgx4NbVH9wGYHQU Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/12/18 3:36 PM, Mathieu Arnold wrote: > On Fri, Oct 12, 2018 at 02:55:38PM -0600, Sean Bruno wrote: >> >> >> On 10/12/18 2:10 PM, Mathieu Arnold wrote: >>> So, you want us to add something like "if the variable EXTRA_PATCHES = is >>> already set before, instead of using =3D, use +=3D"? >>> >>> I don't really see it happening, we are not going to state all the >>> possible cases, the porter's handbook would end up being ISO9001 and = 50k >>> pages long, we assume that you know make(1), so that when you add a >>> variable, you actually look for it in the Makefile to see if it is no= t >>> already set. >> >> I don't think I'm asking for that. >> >> I think I'm asking for "we should have the example be a +=3D instead o= f a >> =3D" because of the DOCS variable and how it behaves. EXTRA_PATCHES >> wasn't in use in this example before I added the openssl1.1.1 patch >> abomination, but I guess, DOCS implicitly means its always in use. >=20 > The example is GENERIC. THIS port has a DOCS option that sets > EXTRA_PATCHES. >=20 Ah, gotcha. I looked around in the handbook to see if I overlooked this behavior. I didn't see it in there, but I may have missed it. sean --ySa79FfN602GWGEoa0hgx4NbVH9wGYHQU-- --QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlvBFelfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LZXOQf7BeAgqu2C2jtcMs00VsV2evxWRyIoxEsDD53g1O1Lh/Om/8ls5HQ0MuJr mDmFKmqcj/9z3NWeh6UBg1rLrCifZ0619NAeCbIFfau4b4wYBf5AP/ABp8XL5X1G BfKDt4EOHq93MRSMbIojWTk14b3jQ4Lk0JZaGABCKO3jPbKBCVgtKuFJ3zJFNIRE NktvViT//fK/rw11jcdwfdEFQ/NeiztNxvCDiyDHGkv8aGT4YCpZsbFmeGkGku/D nCu078N7KGoWCYLp4a5tKyu0HbFX/CCAgw1h2ZIGsCyzhYmlb2mHr/Sb56QXwaWp efx4FwglmZKVozQNkPKEND2UFYE7yw== =XXJW -----END PGP SIGNATURE----- --QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d5bc5542-3ea2-d7d7-2aba-61acab76a94e>