From owner-cvs-src@FreeBSD.ORG Fri Jul 8 21:17:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7435016A42D for ; Fri, 8 Jul 2005 21:17:52 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id B316843D49 for ; Fri, 8 Jul 2005 21:17:51 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru (8.13.0/vak/3.0) id j68LEkfF046746 for cvs-src@FreeBSD.ORG.checked; Sat, 9 Jul 2005 01:14:46 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (localhost.cronyx.ru [127.0.0.1]) by hanoi.cronyx.ru (8.13.0/vak/3.0) with ESMTP id j68LCa5c046732; Sat, 9 Jul 2005 01:12:36 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <42CEEA1A.8090903@cronyx.ru> Date: Sat, 09 Jul 2005 01:03:22 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.2.1) Gecko/20030426 X-Accept-Language: ru-ru, en MIME-Version: 1.0 To: Maxim Sobolev References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> In-Reply-To: <42CECCD8.5070201@portaone.com> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: Roman Kurakin , cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2005 21:17:52 -0000 Maxim Sobolev: > Roman Kurakin wrote: > >> rik 2005-07-08 18:36:59 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/compat/ndis subr_ntoskrnl.c Log: >> Use implicit type cast for ->k_lock to fix compilation of ndis >> as a part of the GENERIC kernel with INVARIANT* and WITNESS* >> turned off. > > I think the better fix is to change type of k_lock member from void* > to the struct mtx*, Probably. I didn't try to find out the reason why it is void *. Probably there was some reasons. I just leave it as is. > I've already commited such change to the RELENG_5 few days ago. Hm. I've checked my mailbox and you commit was marked as unread that means "to check it". If you are sure that there is no any special reason why it is void* (other locks are normal) it worth to fix it your way. rik > -Maxim