From owner-freebsd-net@FreeBSD.ORG Mon Apr 25 14:56:42 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09D6D106564A for ; Mon, 25 Apr 2011 14:56:42 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from zimbra.averesystems.com (75-149-8-245-Pennsylvania.hfc.comcastbusiness.net [75.149.8.245]) by mx1.freebsd.org (Postfix) with ESMTP id A794F8FC08 for ; Mon, 25 Apr 2011 14:56:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zimbra.averesystems.com (Postfix) with ESMTP id F2442446005; Mon, 25 Apr 2011 10:57:13 -0400 (EDT) X-Virus-Scanned: amavisd-new at averesystems.com Received: from zimbra.averesystems.com ([127.0.0.1]) by localhost (zimbra.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SlhqoaFP-SWx; Mon, 25 Apr 2011 10:57:13 -0400 (EDT) Received: from riven.arriad.com (fw.arriad.com [10.0.0.16]) by zimbra.averesystems.com (Postfix) with ESMTPSA id E94FB446001; Mon, 25 Apr 2011 10:57:12 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Andrew Boyer In-Reply-To: <4DB25A9E.5040008@freebsd.org> Date: Mon, 25 Apr 2011 10:56:40 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <40AA1C79-9DCA-49BD-A8E3-63495CC34C6B@averesystems.com> References: <4E85F36598CB480AA8B9706881573CB9@multiplay.co.uk><521514204B99427691043FF127B6E841@multiplay.co.uk> <036FCFE4-98BA-4B90-A060-4597B68A3596@averesystems.com> <4DB25A9E.5040008@freebsd.org> To: Julian Elischer X-Mailer: Apple Mail (2.1084) Cc: freebsd-net@freebsd.org, Jack Vogel Subject: Re: Intel ix (X520) disconnects when manipulating ips? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2011 14:56:42 -0000 On Apr 23, 2011, at 12:50 AM, Julian Elischer wrote: > On 4/22/11 5:08 PM, Andrew Boyer wrote: >> Hello Steve and Jack, >> You need to handle the SIOCSIFADDR ioctl or it gets passed up the = stack to ether_ioctl(). When it goes up the interface gets reset. See = the comments in em_ioctl() and igb_ioctl(). >>=20 >> We fixed this in ixgbe in our internal tree and it seems to work fine = with 82598 and 82599. You also need to include opt_inet.h for the INET = #define to be valid. >=20 > so, what else have you fixed? :-) >=20 >> -Andrew >>=20 Here's a list of suggested improvements that we could give back. I try = to only bother Jack if a problem results in a hang or other serious = issue. - Add tunables for LRO and HWRSC - Add code in ixgbe_attach() to detect 'disabled' hint (call = resource_disabled()) [also useful in e1000!] - Add code in ixgbe_attach() to handle IXGBE_ERR_SFP_NOT_PRESENT = returned by ixgbe_init_hw() (set sfp_probe to TRUE) - Add VLAN_HWTSO support when handling SIOCSIFCAP - Call ixgbe_disable_queue() at the beginning of ixgbe_msix_que() - Add code to ixgbe_local_timer() to first call ixgbe_txeof() on every = queue before checking the queue status - Rework ixgbe_config_link(); if sfp is TRUE, I think it should just = schedule mod_task and let it handle the msf case - Add locking and PHY type detection to ixgbe_handle_link() (to support = copper->optical and optical->copper transitions) - Add locking to ixgbe_handle_mod(), detect the PHY type, and only = schedule msf_task if multispeed_fiber is true - Add locking to ixgbe_handle_msf() I could provide patches for any item that people are interested in = testing / incorporating. Of course Jack still gets the final say on = what goes into ixgbe. -Andrew -------------------------------------------------- Andrew Boyer aboyer@averesystems.com