Date: Mon, 25 Apr 2011 10:56:40 -0400 From: Andrew Boyer <aboyer@averesystems.com> To: Julian Elischer <julian@freebsd.org> Cc: freebsd-net@freebsd.org, Jack Vogel <jack.vogel@intel.com> Subject: Re: Intel ix (X520) disconnects when manipulating ips? Message-ID: <40AA1C79-9DCA-49BD-A8E3-63495CC34C6B@averesystems.com> In-Reply-To: <4DB25A9E.5040008@freebsd.org> References: <4E85F36598CB480AA8B9706881573CB9@multiplay.co.uk><521514204B99427691043FF127B6E841@multiplay.co.uk><BANLkTim8AYL4q63QqRasMm_s9sQ7etBW6g@mail.gmail.com><EFEE51362EF946398B49940E7B869F52@multiplay.co.uk><BANLkTimJpU119K=4-SD56WMBycW08GhkBA@mail.gmail.com> <BANLkTimJX5HPOnX=3hqf0Y=_n-Aqc4UoUg@mail.gmail.com> <A38BF553D0DF4B9385E88EBB2CEDC103@multiplay.co.uk> <036FCFE4-98BA-4B90-A060-4597B68A3596@averesystems.com> <4DB25A9E.5040008@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 23, 2011, at 12:50 AM, Julian Elischer wrote: > On 4/22/11 5:08 PM, Andrew Boyer wrote: >> Hello Steve and Jack, >> You need to handle the SIOCSIFADDR ioctl or it gets passed up the = stack to ether_ioctl(). When it goes up the interface gets reset. See = the comments in em_ioctl() and igb_ioctl(). >>=20 >> We fixed this in ixgbe in our internal tree and it seems to work fine = with 82598 and 82599. You also need to include opt_inet.h for the INET = #define to be valid. >=20 > so, what else have you fixed? :-) >=20 >> -Andrew >>=20 Here's a list of suggested improvements that we could give back. I try = to only bother Jack if a problem results in a hang or other serious = issue. - Add tunables for LRO and HWRSC - Add code in ixgbe_attach() to detect 'disabled' hint (call = resource_disabled()) [also useful in e1000!] - Add code in ixgbe_attach() to handle IXGBE_ERR_SFP_NOT_PRESENT = returned by ixgbe_init_hw() (set sfp_probe to TRUE) - Add VLAN_HWTSO support when handling SIOCSIFCAP - Call ixgbe_disable_queue() at the beginning of ixgbe_msix_que() - Add code to ixgbe_local_timer() to first call ixgbe_txeof() on every = queue before checking the queue status - Rework ixgbe_config_link(); if sfp is TRUE, I think it should just = schedule mod_task and let it handle the msf case - Add locking and PHY type detection to ixgbe_handle_link() (to support = copper->optical and optical->copper transitions) - Add locking to ixgbe_handle_mod(), detect the PHY type, and only = schedule msf_task if multispeed_fiber is true - Add locking to ixgbe_handle_msf() I could provide patches for any item that people are interested in = testing / incorporating. Of course Jack still gets the final say on = what goes into ixgbe. -Andrew -------------------------------------------------- Andrew Boyer aboyer@averesystems.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40AA1C79-9DCA-49BD-A8E3-63495CC34C6B>