From owner-svn-src-head@freebsd.org  Tue Dec 27 10:56:18 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF4D4C93DD2;
 Tue, 27 Dec 2016 10:56:18 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from drew.franken.de (mail-n.franken.de [193.175.24.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "*.franken.de",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 89501159F;
 Tue, 27 Dec 2016 10:56:17 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from [192.168.1.121] (p4FE316D7.dip0.t-ipconnect.de [79.227.22.215])
 (Authenticated sender: macmic)
 by mail-n.franken.de (Postfix) with ESMTPSA id 82F9A721E282E;
 Tue, 27 Dec 2016 11:56:13 +0100 (CET)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: svn commit: r310547 - head/sys/netinet
From: Michael Tuexen <tuexen@freebsd.org>
In-Reply-To: <20161227081940.GL82166@strugglingcoder.info>
Date: Tue, 27 Dec 2016 11:56:13 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <693D4C85-526B-426C-9685-1D463E3C3903@freebsd.org>
References: <201612251737.uBPHbIhd027939@repo.freebsd.org>
 <20161227081940.GL82166@strugglingcoder.info>
To: hiren panchasara <hiren@strugglingcoder.info>
X-Mailer: Apple Mail (2.3259)
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
 autolearn=disabled version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Dec 2016 10:56:18 -0000

> On 27 Dec 2016, at 09:19, hiren panchasara =
<hiren@strugglingcoder.info> wrote:
>=20
> On 12/25/16 at 05:37P, Michael Tuexen wrote:
>> Author: tuexen
>> Date: Sun Dec 25 17:37:18 2016
>> New Revision: 310547
>> URL: https://svnweb.freebsd.org/changeset/base/310547
>>=20
>> Log:
>>  Remove a KASSERT which is not always true.
>>=20
>>  In case of the empty queue tp->snd_holes and tcp_sackhole_insert()
>>  failing due to memory shortage, tp->snd_holes will be empty.
>>  This problem was hit when stress tests where performed by pho.
>>=20
>>  PR:		215513
>>  Reported by:	pho
>>  Tested by:	pho
>>  Sponsored by:	Netflix, Inc.
>>=20
>> Modified:
>>  head/sys/netinet/tcp_sack.c
>=20
> Thanks for the fix, Michael. Can you please MFC this?
Sure. Will do it after 3 days or so. Missed that.

Best regards
Michael
>=20
> Cheers,
> Hiren