From owner-freebsd-virtualization@FreeBSD.ORG  Sat Jun 16 07:30:24 2012
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 896B8106564A
	for <freebsd-virtualization@hub.freebsd.org>;
	Sat, 16 Jun 2012 07:30:24 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 740C38FC19
	for <freebsd-virtualization@hub.freebsd.org>;
	Sat, 16 Jun 2012 07:30:24 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G7UOD5000660
	for <freebsd-virtualization@freefall.freebsd.org>;
	Sat, 16 Jun 2012 07:30:24 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G7UOjq000657;
	Sat, 16 Jun 2012 07:30:24 GMT (envelope-from gnats)
Date: Sat, 16 Jun 2012 07:30:24 GMT
Message-Id: <201206160730.q5G7UOjq000657@freefall.freebsd.org>
To: freebsd-virtualization@FreeBSD.org
From: Mikolaj Golub <trociny@freebsd.org>
Cc: 
Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Mikolaj Golub <trociny@freebsd.org>
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2012 07:30:24 -0000

The following reply was made to PR kern/158686; it has been noted by GNATS.

From: Mikolaj Golub <trociny@freebsd.org>
To: "Daan Vreeken \[PA4DAN\]" <pa4dan@Bliksem.VEHosting.nl>
Cc: bug-followup@FreeBSD.org, Alexander V. Chernikov <melifaro@freebsd.org>
Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
Date: Sat, 16 Jun 2012 10:25:26 +0300

 Hi Daan,
 
 The patch is committed. Thank you!
 
 Note, I have not committed the "FIB" part of the patch though because I am not
 sure it was supposed to be done in this way. Your change looks reasonable for
 me, as it looks like without it mbufs of all incoming packets are not tagged
 on tap interface. On the other hand I don't see examples in kernel where tag
 is set before if_input() call (only before netisr_queue() or netisr_dispatch()).
 if_input() is actually ether_input(). May be it is supposed to just add this tag
 in ether_input()?
 
 I cc Alexander Chernikov, who is the author of the original patch that added
 mbuf tagging of incoming packets (r223741), and close this pr as the vimage
 part is fixed.
 
 -- 
 Mikolaj Golub