From owner-cvs-all@FreeBSD.ORG Mon Mar 17 12:00:46 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C628210656C1; Mon, 17 Mar 2008 12:00:46 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id 8D1B48FC18; Mon, 17 Mar 2008 12:00:46 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.107] (cpe-24-94-75-93.hawaii.res.rr.com [24.94.75.93]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id m2HC0fdJ027644; Mon, 17 Mar 2008 08:00:44 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Mon, 17 Mar 2008 02:01:22 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Maxim Sobolev In-Reply-To: <47DDED1F.8000707@FreeBSD.org> Message-ID: <20080317020036.M910@desktop> References: <200803160621.m2G6LUlE034766@repoman.freebsd.org> <20080316100836.F44049@fledge.watson.org> <47DDED1F.8000707@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys eventhandler.h src/sys/kern kern_descrip.c uipc_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Mar 2008 12:00:47 -0000 On Sun, 16 Mar 2008, Maxim Sobolev wrote: > Robert Watson wrote: >> On Sun, 16 Mar 2008, Maxim Sobolev wrote: >> >>> sobomax 2008-03-16 06:21:30 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/sys eventhandler.h >>> sys/kern kern_descrip.c uipc_socket.c >>> Log: >>> Properly set size of the file_zone to match kern.maxfiles parameter. >>> Otherwise the parameter is no-op, since zone by default limits number >>> of descriptors to some 12K entries. Attempt to allocate more ends up >>> sleeping on zonelimit. >> >> Hmm. Could you be more specific about the nature of the problem you're >> seeing here? UMA shouldn't impose any default zone limit on the file_zone >> if none is set. Are you sure it's the struct file zonelimit you're running >> into, and not, say, the socket zone limit, etc? > > Yes, you are right, further investigation revealed that in my case I was > hitting maxsockets limit, not maxfiles limit. Not sure if the backout is in > order or having files zone limit has some value, so that possible leaks can > be detected and UMA zone can potentially do size-based optimizations in the > future? The UMA max is complicated due to per-cpu caches. Really the limit code in uma should be rewritten or all consumers should handle it themselves the way struct file does. It'd probably be best if you backed this out. Thanks, Jeff > >> Also, don't use SI_SUB_EVENTHANDLER+1 -- add a new event type, perhaps >> SI_SUB_FILE, or use SI_ORDER_LAST. > > OK, what about maxsockets code? Should it be changed to? > > -Maxim >