Date: Sat, 11 May 2019 12:43:10 +0200 From: Adriaan de Groot <adridg@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r501243 - head/net/freeswitch Message-ID: <1807231.EnoYUHA41c@beastie.bionicmutton.org> In-Reply-To: <201905110955.x4B9teAQ032692@repo.freebsd.org> References: <201905110955.x4B9teAQ032692@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1914105.9KSsKqBpt2
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
On Saturday, 11 May 2019 11:55:40 CEST Tobias Kortkamp wrote:
> net/freeswitch: Fix build and disable -Werror to stop collecting -Wno-*
> flags
Why not patch it to do the right thing? With patches you might even be able to
move things upstream, .. or chase the latest release, since upstream seems to
be doing monthlies now (there is a 1.8.5, which still contains the same
problem).
The underlying error is that the code is doing, basically,
strlen("derp"+1)
where it's adding one to a string constant; clang helpfully (? if you're used
to javascript perhaps) tells you this isn't going to get you "derp1" as a
string, but rather "erp" .. which is exactly what this code wants, but it
could be done in a less-derpy and less error-prone way (e.g. &"derp"[1]).
I guess I'm saying I'm not a fan of turning off warnings and errors unless
it's really hopeless upstream.
[ade]
--nextPart1914105.9KSsKqBpt2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit
-----BEGIN PGP SIGNATURE-----
iHUEABEIAB0WIQTVFBoRsP760fy+Jisy7lRaPghTTwUCXNanPgAKCRAy7lRaPghT
T81bAP9F1EjHc3xht+NGhb5/PJC3P2Uu4sIgqVw2/T4jrzozYgD+K1lk58BthoHS
mZ2QIlUlBT/ZvXEc00Ivmn+mqpUeWWo=
=knws
-----END PGP SIGNATURE-----
--nextPart1914105.9KSsKqBpt2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1807231.EnoYUHA41c>