From owner-freebsd-current@FreeBSD.ORG Tue Oct 7 12:25:53 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2124216A4B3 for ; Tue, 7 Oct 2003 12:25:53 -0700 (PDT) Received: from zibbi.icomtek.csir.co.za (zibbi.icomtek.csir.co.za [146.64.24.58]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9721743FE5 for ; Tue, 7 Oct 2003 12:25:49 -0700 (PDT) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: from zibbi.icomtek.csir.co.za (localhost [IPv6:::1]) h97JPkqs039980; Tue, 7 Oct 2003 21:25:47 +0200 (SAST) (envelope-from jhay@zibbi.icomtek.csir.co.za) Received: (from jhay@localhost) by zibbi.icomtek.csir.co.za (8.12.9/8.12.9/Submit) id h97JPjiu039979; Tue, 7 Oct 2003 21:25:45 +0200 (SAST) (envelope-from jhay) Date: Tue, 7 Oct 2003 21:25:45 +0200 From: John Hay To: Bruce M Simpson Message-ID: <20031007192545.GA39644@zibbi.icomtek.csir.co.za> References: <20031004190217.GA10149@zibbi.icomtek.csir.co.za> <20031007180202.GA37174@zibbi.icomtek.csir.co.za> <20031007181109.GF73063@saboteur.dek.spc.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031007181109.GF73063@saboteur.dek.spc.org> User-Agent: Mutt/1.4i cc: current@freebsd.org Subject: Re: umass panic when connecting camera X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Oct 2003 19:25:53 -0000 On Tue, Oct 07, 2003 at 07:11:10PM +0100, Bruce M Simpson wrote: > On Tue, Oct 07, 2003 at 08:02:02PM +0200, John Hay wrote: > > Any comments from people a little more knowledgable in the umass/usb > > area? > > I don't know about USB specifically, but I thought timeout() et al were > to be deprecated in favour of callout*() ? Well I just wanted to get my device working again without changing the code too much, so I added an untimeout() for the existing timeout(). The usb code is also shared with the other *BSD groups. Looking at the rest of the usb files, I see that they do use usb_callout*(), so one can probably convert umass to it. The man page for (un)timeout and callout* is interesting because it does say that timeout() "is the old style and new code should use the callout_* functions" but a little later it also says "The functions callout_init(), callout_stop() and callout_reset() are low- level routines for clients who wish to allocate their own callout struc- tures." :-) John -- John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org