From owner-freebsd-bugs@freebsd.org Fri Jan 3 20:02:25 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CBC431E1E75 for ; Fri, 3 Jan 2020 20:02:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47qG5s52rBz4J2W for ; Fri, 3 Jan 2020 20:02:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id AD1391E1E74; Fri, 3 Jan 2020 20:02:25 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACD721E1E72 for ; Fri, 3 Jan 2020 20:02:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47qG5s4Cm3z4J2V for ; Fri, 3 Jan 2020 20:02:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8C09816EB for ; Fri, 3 Jan 2020 20:02:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 003K2PZa083831 for ; Fri, 3 Jan 2020 20:02:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 003K2PUu083830 for bugs@FreeBSD.org; Fri, 3 Jan 2020 20:02:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 243064] mount_unionfs panics in latest -current Date: Fri, 03 Jan 2020 20:02:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mason@blisses.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 20:02:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243064 --- Comment #4 from Mason Loring Bliss --- The amazing folks in Freenode #freebsd have nailed it down: 14:47 < RhodiumToad> everywhere else, VOP_UNLOCK is called as VOP_UNLOCK(vp= ,0) 14:48 < RhodiumToad> unionfs uses VOP_UNLOCK(vp,LK_RELEASE), which I suspec= t is=20 just an obsolete form from years back ... 14:51 < RhodiumToad> anyway, unionfs can probably be fixed trivially 14:52 < kevans91> yeah, looks like it just has a dozen or so VOP_UNLOCK=20 invocations that are incorrect related: 14:50 < kevans91> I thought mjg was cooking up something to drop the second= =20 argument entirely 14:50 < kevans91> ah, yeah: - Exp-run PR 240156 to remove flags argument fr= om=20 VOP_UNLOCK 14:50 < VimDiesel> 240156 =E2=80=93 Remove flags argument from VOP_UNLOCK=20 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D2401= 56 14:51 < kevans91> https://reviews.freebsd.org/D21427 14:51 < VimDiesel> Title: =E2=9A=99 D21427 vfs: remove flags argument from = VOP_UNLOCK=20 (at reviews.freebsd.org) --=20 You are receiving this mail because: You are the assignee for the bug.=