From owner-cvs-all@FreeBSD.ORG  Tue Jul 19 16:00:07 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A46F71065673;
	Tue, 19 Jul 2011 16:00:06 +0000 (UTC)
	(envelope-from jhein@gossamer.timing.com)
Received: from mout.perfora.net (mout.perfora.net [74.208.4.195])
	by mx1.freebsd.org (Postfix) with ESMTP id E9D088FC1F;
	Tue, 19 Jul 2011 16:00:05 +0000 (UTC)
Received: from gossamer.timing.com ([206.168.13.144])
	by mrelay.perfora.net (node=mrus2) with ESMTP (Nemesis)
	id 0Lvljw-1RWcJw0FiO-017M6T; Tue, 19 Jul 2011 11:47:21 -0400
Message-ID: <20005.42751.457047.15851@gossamer.timing.com>
Date: Tue, 19 Jul 2011 09:47:11 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: John Hein <jhein@symmetricom.com>
To: Doug Barton <dougb@FreeBSD.org>
In-Reply-To: <4E2542BA.5040203@FreeBSD.org>
References: <201107190333.p6J3XQVD050847@repoman.freebsd.org>
	<4E2542BA.5040203@FreeBSD.org>
X-Mailer: VM 8.0.12 under 22.3.1 (i386-redhat-linux-gnu)
X-Provags-ID: V02:K0:JZQhNtCx+3TgtAF0XsR5Zy1KMP/zV7kTKs/dhMLRips
	mPyrMMPf7HHNWzEbQW5N5uvIheHb21HyBzLp58D2xESNRcW2vv
	30dE1OzbC74yb0NDhQwpfl+7f8r3ATBPFrZwo0kWcpMn8wNZtA
	H9/nxvbvuyWZgQGmNm0rCgm6MZTv2FgnSkw+9e1ip5FE/O2j4H
	vYhDU7+0CLKMIIDBuAVVg==
Cc: vanhu@netasq.com, Stephen Montgomery-Smith <stephen@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org,
	maho@FreeBSD.org, cvs-ports@FreeBSD.org
Subject: Re: cvs commit: ports/security/ipsec-tools Makefile
 ports/security/ipsec-tools/files racoon.sh.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jul 2011 16:00:08 -0000

Doug Barton wrote at 01:39 -0700 on Jul 19, 2011:
 > This change is an improvement, but it doesn't go far enough in a couple
 > of directions. The 2 most important being that faststart is not the only
 > possible prefix there, and we don't want that block to run
 > unconditionally in any case.
 > 
 > I've attached the full script I'm suggesting because the diff doesn't
 > make much sense. One thing I didn't change because I'm not sure if it
 > needs to be run early is changing the current require/before to just
 > REQUIRE: LOGIN, which is what we prefer ports scripts to do. However if
 > there is a good reason for this one to run earlier, that's fine.
 > 
 > If you have any questions, let me know.

Yes, looks good to me.  Well, except the spelling issues:

sed -E 's,(raccon|raccoon),racoon,g'


I'm not sure if there are some lurking subtleties regarding the
require/before question.  I'll let Yvan answer that.  Commit
history doesn't say anything - it's been REQUIRE: DAEMON &
BEFORE: LOGIN since the beginning - probably just copy/pasted.