From owner-freebsd-bugs  Sat Jan 11 07:00:04 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id HAA19926
          for bugs-outgoing; Sat, 11 Jan 1997 07:00:04 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id HAA19917;
          Sat, 11 Jan 1997 07:00:02 -0800 (PST)
Resent-Date: Sat, 11 Jan 1997 07:00:02 -0800 (PST)
Resent-Message-Id: <199701111500.HAA19917@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, thompson@tgsoft.com
Received: from squirrel.tgsoft.com (squirrel.tgsoft.com [207.167.64.183])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id GAA19738
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Jan 1997 06:54:53 -0800 (PST)
Received: (from thompson@localhost) by squirrel.tgsoft.com (8.8.3/8.6.12) id GAA15414; Sat, 11 Jan 1997 06:56:40 -0800 (PST)
Message-Id: <199701111456.GAA15414@squirrel.tgsoft.com>
Date: Sat, 11 Jan 1997 06:56:40 -0800 (PST)
From: mark thompson <thompson@tgsoft.com>
Reply-To: thompson@tgsoft.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/2449: nit in ij-ppp
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         2449
>Category:       bin
>Synopsis:       ij-ppp in auto mode goes into failure loop
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 11 07:00:01 PST 1997
>Last-Modified:
>Originator:     mark thompson
>Organization:
tgsoft
>Release:        FreeBSD 2.1-960627-SNAP i386
>Environment:

Using user-mode ppp in auto mode.

>Description:

If ppp ever gets to the line:
      LogPrintf(LOG_PHASE_BIT, "** 1 Too many ECHO packets are lost. **\n");
It will get there every time until killed, because the counter "lqrsendcnt"
does not get reset.

>How-To-Repeat:

Best way to reproduce this is to have the receiving end refuse to
anwer pings for a while, then bring it back.

>Fix:
	
diff -r -u ../FreeBSD.2.2/src/usr.sbin/ppp/lqr.c Root/usr/src/usr.sbin/ppp/lqr.c
--- ../FreeBSD.2.2/src/usr.sbin/ppp/lqr.c	Sat May 11 13:48:33 1996
+++ Root/usr/src/usr.sbin/ppp/lqr.c	Fri Jan 10 05:06:26 1997
@@ -189,6 +189,7 @@
   struct lcpstate *lcp = &LcpInfo;
   int period;
 
+  lqrsendcnt = 0;	/* start waiting all over for ECHOs */
   lqmmethod = LQM_ECHO;
   if (Enabled(ConfLqr))
     lqmmethod |= LQM_LQR;


>Audit-Trail:
>Unformatted: