From owner-freebsd-ports@freebsd.org Tue Apr 7 15:35:57 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 270F327288F for ; Tue, 7 Apr 2020 15:35:57 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48xWhX1VNcz3KwM for ; Tue, 7 Apr 2020 15:35:55 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wm1-x32e.google.com with SMTP id h2so2184155wmb.4 for ; Tue, 07 Apr 2020 08:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4vAy4BSgtFvHfnIruXaKCsnZQFnxRyEqaXF/nv9MOv8=; b=qHec3GF9WeXcBCwP9uZff9sIyxp9SfPYbNgCxhZGfohhqlq0I9H8f4EeFFBNGrCZAG bkS1FoD8WKXZwswHBu0yzakN+ruLLdeuQVk0ToIo+KxoADtGGaDAVf4HxivZplGmIji+ 7FvOp5rXgMmNfsV2yj324XqlGfKcQllcsgtv4InTwn1cZP6RA+vVN5AP6sgGo5qd87FC uXTsF0ekmQlV+KLiIvPxuAIaHD5ky+jXvzzFI5z2P7vyMTK9JtfGwQkNaQ75ATbUeKfp ToN1cn/KAlj7dGI16ez38zvKZXymTf2Q7n3PGJKzpBeHqNY1k/dkg0o7rZR6Knyy4sRC TR4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4vAy4BSgtFvHfnIruXaKCsnZQFnxRyEqaXF/nv9MOv8=; b=uTPPsC2u7OevSXdiUEXaLpI+zM4Do11QGbsJPOqzAEReFKyRdt3hcxFJpjHUUtCGSZ /kDeZtIzuHo/t6w4ELPVMmcIf+d22y4Gc2zw2dVn2e4XVNl5hmxlUTxkgYd9Pxfd6Tqf MFYDeF5RddpgWTLpau6h5V2O1w08nEUppLdBPK/TnxvPTxk8yHrxR4VKlvRWpTS8C7ZW 0K2RLk2hpZ/bT7mKfmBpaCBpq0Dz+t7opBsmEZOIGEDsA4UJJGE0IyImikjd+76AcjTx om1Tbu7wuVR6mAO+gZrUg5QDIDe0PiAlHUqJE5GZXju5Qht6zD6OZvJ0+TfEu9+QnYmB 2MHg== X-Gm-Message-State: AGi0PuYCsBfjzfU4KJS8eJ5WIdJuPrZVJvcnoUjf8U4CZkeYjIN2MvHq ydzWYmJFUu6YB0iNSqXQsCim4m5j7Z0y/BtfA4G3KDvq X-Google-Smtp-Source: APiQypLyCe+sU10iXUU4TCLM4n3b+iJi1AJGrQ28t4+J6i3L/Jn0AjQtmNDcLF0M6vwhmocBrJuWYwLEsTpO50bY30s= X-Received: by 2002:a7b:c5cb:: with SMTP id n11mr3087330wmk.160.1586273754408; Tue, 07 Apr 2020 08:35:54 -0700 (PDT) MIME-Version: 1.0 References: <2970225.0P3pStmDMi@heimdall> In-Reply-To: <2970225.0P3pStmDMi@heimdall> From: Adam Weinberger Date: Tue, 7 Apr 2020 09:35:38 -0600 Message-ID: Subject: Re: Running tests in ports Makefiles? To: Adam Jimerson Cc: "freebsd-ports@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48xWhX1VNcz3KwM X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=qHec3GF9; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::32e as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-3.89 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; DMARC_NA(0.00)[adamw.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[e.2.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.39)[ip: (-9.12), ipnet: 2a00:1450::/32(-2.36), asn: 15169(-0.43), country: US(-0.05)]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 15:35:57 -0000 On Tue, Apr 7, 2020 at 5:17 AM Adam Jimerson wrote: > > Hello all, > > Hopefully a quick question, is it common place in the ports tree to run tests > for the software being ported in the Makefile or should we just expect/ > encourage upstream to do tests for FreeBSD and leave it at that? > > I ask because one of the ports that I am maintaining is written in Go, uses > the standard test suite that is built into the Go tool chain which means no > additional dependencies to be able to add this only a slightly longer build > time, currently `make package` takes 27.8 seconds on a system with a 16 CPU > cores and 32 Gb ram. Optional tests should never be run during a normal build. There is a "do-test:" target for that purpose. Can you fold the test suite into that target? # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org