From nobody Sat Feb 24 09:32:00 2024 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ThhVW4Qkkz5CQnq for ; Sat, 24 Feb 2024 09:32:19 +0000 (UTC) (envelope-from einar@isnic.is) Received: from mx01.isnic.is (mx01.isnic.is [193.4.58.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx01.isnic.is", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ThhVV60WQz4Vnh; Sat, 24 Feb 2024 09:32:18 +0000 (UTC) (envelope-from einar@isnic.is) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=isnic.is header.s=20200921 header.b=eYjLKXk0; dmarc=pass (policy=quarantine) header.from=isnic.is; spf=pass (mx1.freebsd.org: domain of einar@isnic.is designates 193.4.58.133 as permitted sender) smtp.mailfrom=einar@isnic.is Received: from ht-mailstore01.isnic.is (ht-mailstore01.isnic.is [IPv6:2001:67c:6c:56::2]) by mx01.isnic.is (Postfix) with ESMTPS id EFB8C24ECE; Sat, 24 Feb 2024 09:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isnic.is; s=20200921; t=1708767131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qQkvjNsbasxdB7bq/oXrGkdM+Cq0tZAGPCSrAxscd4E=; b=eYjLKXk0IxCR0H9jq5mWeugnAOJABfJbbjZXH0SOh96vmR+DMOaQQl6G5zpCOdJUbfIuwJ P2BEjrlyIlvqix4xO9Qu/2/PV+Lx6NQ/0UKLUD3FMG08IHyECxnfxN2m/8mgjSTq/qIE2J QDCFuWqXszeCwQ7WtyxDzTwAu0Yn2DNkNkJ4o5B/OSMdQkwCMTFRxfkMBIQ2/8C6Qgqvp1 M69dtKz13QkGbhZWtupJEdsqDFgmUUTSW7MXLlKk2FRIa+F/8hhGSp2zB3o4sWZcw62qBu kP3hZosuBI7D5Fidl5vDF2qQKJ38Fqf946OclBZV71OvrouvqE4Q0lY9M0oqdQ== Received: from smtpclient.apple (unknown [185.93.159.194]) by ht-mailstore01.isnic.is (Postfix) with ESMTPS id E4C6A23367; Sat, 24 Feb 2024 09:32:10 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\)) Subject: Re: Multiple new R ports From: =?utf-8?Q?Einar_Bjarni_Halld=C3=B3rsson?= In-Reply-To: <2E6761A6-F462-4B83-94AC-9658583A581D@isnic.is> Date: Sat, 24 Feb 2024 09:32:00 +0000 Cc: ports@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <6A36BE5B-2C76-434D-8EFF-D9518DA7E6E6@isnic.is> References: <44F61FC1-532F-447F-80E9-83ED37599CD7@isnic.is> <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> <2E6761A6-F462-4B83-94AC-9658583A581D@isnic.is> To: Nuno Teixeira X-Mailer: Apple Mail (2.3774.400.31) X-Spamd-Bar: --- X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; DMARC_POLICY_ALLOW(-0.50)[isnic.is,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:193.4.58.0/23:c]; R_DKIM_ALLOW(-0.20)[isnic.is:s=20200921]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:1850, ipnet:193.4.58.0/23, country:IS]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[ports@freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[isnic.is:+] X-Rspamd-Queue-Id: 4ThhVV60WQz4Vnh > On 24 Feb 2024, at 06:24, Einar Bjarni Halld=C3=B3rsson = wrote: >=20 >> On 22 Feb 2024, at 11:43, Nuno Teixeira wrote: >>=20 >> I did take a look at review and noticed that TEST_DEPENDS are not = used >> and that could means that test target works without any depends or >> ports are not tested at all. >> My curiosity is what do you think about the importance (or not) to >> have testunit feature working on R ports? >>=20 I=E2=80=99ve got tests working on all the ports, except for = R-cran-systemfonts. I have a PR [1] for upstream to fix that. Tests do give out notice that suggested packages aren=E2=80=99t = installed to be tested, what=E2=80=99s your opinion on that? I don=E2=80=99t want to add too = much to the packages and I definately don=E2=80=99t want to add options at this moment. Would it be fine to add the ports as is, without suggested packages? .einar [1] https://github.com/r-lib/systemfonts/pull/111=