From owner-freebsd-current@freebsd.org Sat Feb 13 20:21:23 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4EE13AA80BB for ; Sat, 13 Feb 2016 20:21:23 +0000 (UTC) (envelope-from freebsd@go4more.de) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.kundenserver.de", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B456C18F3 for ; Sat, 13 Feb 2016 20:21:21 +0000 (UTC) (envelope-from freebsd@go4more.de) Received: from [80.132.215.157] by 3capp-1and1-bs02.server.lan (via HTTP); Sat, 13 Feb 2016 21:21:06 +0100 MIME-Version: 1.0 Message-ID: From: "Stefan Kohl" To: "Marius Strobl" Cc: pyunyh@gmail.com, freebsd-current@freebsd.org Subject: Aw: Re: Re: Realtek 8168/8111 if_re not working in current r295091 Content-Type: text/plain; charset=UTF-8 Date: Sat, 13 Feb 2016 21:21:06 +0100 Importance: normal Sensitivity: Normal In-Reply-To: <20160205212912.GI15359@alchemy.franken.de> References: <20160204005132.GA1181@michelle.fasterthan.co.kr> , <20160205212912.GI15359@alchemy.franken.de> Content-Transfer-Encoding: quoted-printable X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K0:+M44Th4fehKLEVH1gZr+/riECvaqQ3/N+bwg8yJeDQu XvZPJvHFM/5+2UDHBTSjO4ib5FE2yHi1FrXpngXG1hF1wP7eUk fOxqZ+a5fEF/5mCvELJUyvlTOyVcOnpD+21q98piLx2wFRQGrM LrDhMcjB0LanC8GlIQui+IgYSeerqfoSeEBbizJWp8ysqQY2rn 0CcWKTQtkJ48/A2s9flVHRtVA9GrLtA8rcIuDE6y8JjP/Gmuwy d8ibir9BNEPI9s9I8ZHlgh8ZKYu7NBdS/AXC/DN7ghHpsLh/v1 BCTZeU= X-UI-Out-Filterresults: notjunk:1;V01:K0:xfpn4j72FGY=:XUHNE3t14VVym22KIMktLi 5cSEKqc/5MtcSGEFhrfUgHBRElN2a20ejOVPEZqH/DASqvwWxE1WtdmRIZmHTa607LqoieBmy 9R6dlPaXFOvdPYFFwZI7w4RmxBhWODmVuH1nhsHXqWdTpOJK+9F+9wrWqZYu5LAvFMY9fTj7I Y5kSZFYnFsX64b3DfM/BfmQJEJF9HwecFqdjEKARjUgp4WHc0Rdh0DKdwmrshbfk1WB6Cmgv9 ro1BxkS/XYmBgDjEGqH1v6kZyjXQ1RtZP45Sh3ixnL1/RMzu3HtOMhzI0u9H/XijrYEgC6rop 3msbyl X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2016 20:21:23 -0000 Hi Marius, I finally got my RT 8168 Ethernet Card (Zotac Ri323) working after patching if_re=2Ec (r295601)=2E Contrary to the assumption that HWREV_8168E_VL with Chip Rev 0x2c800000 should not require RTL8168G handling as soon as I expand the sc->rl_flags for the respective HWREV and define the (ominous) 8168G_Plus Flag for RL_HWREV_8168E_VL the card is functioning correctly=2E /usr/src/sys/dev/re # svn diff if_re=2Ec Index: if_re=2Ec =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- if_re=2Ec (revision 295601) +++ if_re=2Ec (working copy) @@ -1473,6 +1473,8 @@ RL_FLAG_WOL_MANLINK; break; case RL_HWREV_8168E_VL: + sc->rl_flags |=3D RL_FLAG_8168G_PLUS; + /* FALLTHROUGH */ case RL_HWREV_8168F: sc->rl_flags |=3D RL_FLAG_EARLYOFF; /* FALLTHROUGH */ My system: FreeBSD kartal=2Enet=2Ehayat 11=2E0-CURRENT FreeBSD 11=2E0-CURR= ENT #0 r295601: Sat Feb 13 19:11:05 CET 2016 root@kartal=2Enet=2Ehayat:/usr/obj/usr/src/sys/KARTAL amd64 When broken (without the patch) I got the following tcpdump output: 19:18:46=2E299360 00:00:00:00:00:00 (oui Ethernet) > 00:00:00:00:00:00 (oui Ethernet) Null Information, send seq 0, rcv seq 0, Flags [Command], length 84 Regards, Stefan Gesendet:=C2=A0Freitag, 05=2E Februar 2016 um 22:29 Uhr Von:=C2=A0"Marius Strobl" An:=C2=A0s=2Eo=2Ek@web=2Ede Cc:=C2=A0pyunyh@gmail=2Ecom, freebsd-current@freebsd=2Eorg Betreff:=C2=A0Re: Re: Realtek 8168/8111 if_re not working in current r2950= 91 On Fri, Feb 05, 2016 at 09:04:02PM +0100, s=2Eo=2Ek@web=2Ede wrote: > Hi Marius and Pyun, > > actually it is Chip rev=2E 0x2c800000 (I have overlooked that informatio= n in my first post) > > re0: port 0x= e000-0xe0ff mem 0xf0104000-0xf0104fff,0xf0100000-0xf0103fff irq 19 at devic= e 0=2E0 on pci2 > re0: Using 1 MSI-X message > re0: turning off MSI enable bit=2E > re0: Chip rev=2E 0x2c800000 > re0: MAC rev=2E 0x00100000 > miibus0: on re0 > rgephy0: PHY 1 on miibu= s0 > > Does that help in any way? Thanks Stefan > Unfortunately, it doesn't make a whole lot of sense to me; 0x2c800000 translates to RL_HWREV_8168E_VL, which is an older chip that should never have required the handling of RTL8168G and later revisions (or may not actually work when applying it)=2E So r290566 should only make a positive difference, if it changes anyting for that revision all=2E Did the interface work before r290151, or actually before r281337? Does reverting r290946 and r290566 locally make it work again? Another candidate causing that breakage would be r291676 if the PHY is an RTL8211F one=2E If you boot verbosely, you'll have a line in the dmesg(8) output with "OUI 0x00e04c" in it=2E If the "rev=2E" number in that line is 6, you have an RTL8211F=2E Marius _______________________________________________ freebsd-current@freebsd=2Eorg mailing list https://lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd=2Eor= g"