Date: Sun, 16 Jul 2006 12:51:55 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Mark Knight <markk@knigma.org> Cc: freebsd-fs@freebsd.org, freebsd-stable@freebsd.org Subject: Re: 6.1 panic after approx. 49 days uptime Message-ID: <20060716095155.GN32624@deviant.kiev.zoral.com.ua> In-Reply-To: <20060716091925.GM32624@deviant.kiev.zoral.com.ua> References: <NCWGF4BvmfuEFwrU@lap.knigma.org> <20060716084210.GL32624@deviant.kiev.zoral.com.ua> <giDNdZC5zfuEFwMa@lap.knigma.org> <20060716091925.GM32624@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sun, Jul 16, 2006 at 12:19:25PM +0300, Kostik Belousov wrote:
> On Sun, Jul 16, 2006 at 09:46:49AM +0100, Mark Knight wrote:
>
> Index: mount.h
> ===================================================================
> RCS file: /usr/local/arch/ncvs/src/sys/sys/mount.h,v
> retrieving revision 1.210
> diff -u -r1.210 mount.h
> --- mount.h 5 May 2006 19:32:35 -0000 1.210
> +++ mount.h 16 Jul 2006 09:15:32 -0000
> @@ -578,7 +578,7 @@
> int _locked; \
> struct mount *_MP; \
> _MP = (MP); \
> - if (VFS_NEEDSGIANT(_MP)) { \
> + if (_MP != NULL && VFS_NEEDSGIANT(_MP)) { \
> mtx_lock(&Giant); \
> _locked = 1; \
> } else \
This is not needed, since the problem was fixed on HEAD and RELENG_6
by tegge, see rev. 1.210 of sys/sys/mount.h. Fix was committed after
release of 6.1.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (FreeBSD)
iD8DBQFEugw6C3+MBN1Mb4gRAkDHAJ0RpVAee7yMKXDo8KbN+he6JrALSgCguSMo
eSDqDb4/q0lK7qiX5zvRsd4=
=yT0z
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060716095155.GN32624>