Date: Tue, 18 Jan 2005 10:18:57 +0100 From: Florent Thoumie <flz@xbsd.org> To: Jeremie Le Hen <jeremie@le-hen.org> Cc: freebsd-ports@freebsd.org Subject: Re: WITHOUT_X11 knob for mplayer Message-ID: <41ECD481.4020308@xbsd.org> In-Reply-To: <20050118085557.GP36629@obiwan.tataz.chchile.org> References: <20050118085557.GP36629@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jeremie Le Hen wrote: > Hi, > > I'm using mplayer as an MP3 mplayer on a small computer on which I don't > want to install any graphical interface. Thus I added the WITHOUT_X11 > knob for the mplayer port. The patch is attached. Note that I added > an explicit dependency on imake in this case since mplayer requires it > to build. You should consider using USE_IMAKE=yes rather than adding imake-6 to BUILD_DEPENDS, since imake-6 is assuming that everyone uses xorg as X_WINDOW_SYSTEM. > Does this make sense to you to have this knob ? I don't think it's a > great deal anyway, the default behaviour stays unchanged. Should I > submit a PR for this (and get it lost for months ;-) ) ? You can send a PR if you have no answer from the actual maintainer. BTW, it's often a good idea to send a PR, to keep a track :) -- Florent Thoumie flz@xbsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41ECD481.4020308>