From owner-freebsd-bugs Wed Sep 22 17:44:17 1999 Delivered-To: freebsd-bugs@freebsd.org Received: from axl.noc.iafrica.com (axl.noc.iafrica.com [196.31.1.175]) by hub.freebsd.org (Postfix) with ESMTP id BCD1C15055 for ; Wed, 22 Sep 1999 17:44:02 -0700 (PDT) (envelope-from sheldonh@axl.noc.iafrica.com) Received: from sheldonh (helo=axl.noc.iafrica.com) by axl.noc.iafrica.com with local-esmtp (Exim 3.02 #1) id 11Twz6-0005Tn-00; Thu, 23 Sep 1999 02:43:40 +0200 From: Sheldon Hearn To: Doug Cc: peter.jeremy@alcatel.com.au, FreeBSD-bugs@FreeBSD.ORG Subject: Re: bin/13909: /etc/security problems: IPFIREWALL and passwd comments In-reply-to: Your message of "Wed, 22 Sep 1999 17:30:38 MST." Date: Thu, 23 Sep 1999 02:43:40 +0200 Message-ID: <21066.938047420@axl.noc.iafrica.com> Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Wed, 22 Sep 1999 17:30:38 MST, Doug wrote: > The current awk bit ignores blank lines so I don't see that as a > problem. I have both blank lines and comments in my master.passwd . The current code spews all of both kinds of line. Jeremy's variation on the theme spews the blank lines. Makes for an pretty anoying e-mail message when you have enough blank lines. :-) I'm not pointing out a problem with the patch, just another nit to squish at the same time. I'm no awk person, but I imagine something along these lines might work: awk -F: '$1 !~ /^([#+]|[ \t]*$)/ && $2=="" {print $0}' \ /etc/master.passwd Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message