Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Nov 2011 10:39:21 +0800
From:      Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To:        Jeremie Le Hen <jeremie@le-hen.org>
Cc:        freebsd-ports@FreeBSD.org
Subject:   Re: [sysutils/pwsafe] Useless X11 dependency
Message-ID:  <20111117023921.GB7628@bonjour.sunpoet.net>
In-Reply-To: <20111116214718.GD11894@felucia.tataz.chchile.org>
References:  <20111116214718.GD11894@felucia.tataz.chchile.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--3Gf/FFewwPeBMqCJ
Content-Type: multipart/mixed; boundary="4jXrM3lyYWu4nBt5"
Content-Disposition: inline


--4jXrM3lyYWu4nBt5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 16, 2011 at 10:47:19PM +0100, Jeremie Le Hen wrote:
> Hi,
>=20
> Pleaese Cc: me when replying, I'm not subscribed.
>=20
> I'm using sysutils/pwsafe on a headless server.  My recent upgrade of
> the port pulled in numerous useless X11 libs.
>=20
> - The port doesn't seem to agree to issue the password on the terminal
>   anymore;
> - The port compiles cleanly when the Makefile is reverted to rev 1.4.
>=20
> Can you please revert your change, or at least provide a WITHOUT_X11
> knob as many other ports?
>=20
> Thanks.
> Regards,
> --=20
> Jeremie Le Hen
>=20
> Men are born free and equal.  Later on, they're on their own.
> 				Jean Yanne

Hi,

Please test the attached patch. It defaults to not bring in X11 deps.
If it works, I'll submit a PR for it.
Thanks.

Regards,
sunpoet

--4jXrM3lyYWu4nBt5
Content-Type: text/plain; charset=utf-8
Content-Description: pwsafe.patch
Content-Disposition: attachment; filename="diff,pwsafe"
Content-Transfer-Encoding: quoted-printable

Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/pcvs/ports/sysutils/pwsafe/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	21 Oct 2011 02:28:23 -0000	1.5
+++ Makefile	17 Nov 2011 01:58:46 -0000
@@ -7,7 +7,7 @@
=20
 PORTNAME=3D	pwsafe
 PORTVERSION=3D	0.2.0
-PORTREVISION=3D	1
+PORTREVISION=3D	2
 CATEGORIES=3D	sysutils
 MASTER_SITES=3D	http://nsd.dyndns.org/pwsafe/releases/
=20
@@ -18,19 +18,25 @@
=20
 GNU_CONFIGURE=3D	yes
 USE_GMAKE=3D	yes
-USE_XORG=3D	ice sm x11 xmu
=20
 MAN1=3D		pwsafe.1
 PLIST_FILES=3D	bin/pwsafe
=20
-.include <bsd.port.pre.mk>
+.if defined(WITH_X11)
+CONFIGURE_ARGS=3D	--with-x
+USE_XORG=3D	ice sm x11 xmu
+.else
+CONFIGURE_ARGS=3D	ac_cv_have_x=3D"have_x=3Dno" \
+		ac_cv_lib_ICE_IceConnectionNumber=3Dno \
+		ac_cv_lib_X11_XOpenDisplay=3Dno \
+		ac_cv_lib_Xmu_XmuInternAtom=3Dno
+.endif
=20
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/pwsafe ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/pwsafe.1 ${PREFIX}/man/man1
+	${INSTALL_PROGRAM} ${WRKSRC}/pwsafe ${PREFIX}/bin/
+	${INSTALL_MAN} ${WRKSRC}/pwsafe.1 ${MAN1PREFIX}/man/man1/
 .if defined(WITH_SETUID)
 	${CHMOD} u+s ${PREFIX}/bin/pwsafe
 .endif
=20
-.include <bsd.port.post.mk>
-
+.include <bsd.port.mk>

--4jXrM3lyYWu4nBt5--

--3Gf/FFewwPeBMqCJ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQIcBAEBAgAGBQJOxHPYAAoJENxEJH7MV+NrzXcP/RJUMQrwsJNayL4OBn9RxQ3I
HlviNVQ8Huz+SfyxEvzq+eviYOR02N2YMSiVMgr4yCDWjQ8TC2UciBgIQawYP8xm
zvEbpmg69YZloL63JTzEWZ16bPbTSZX9M8eNV8Yxv2eczAHF5zFDaAkLeHL2Qt1J
MD1yfYGSow3Bu21CjHmFqTJZOQO5O3upgJ8V3f7Ma4meIKujCGvO0GJOYwCql2JU
qmSj618wjiifMWFRBaSeE7KBJKxiQOYtVhmjnFQFXd2Z7K6CJF/Flw2YaXseJC3y
6U5VzQebL/F+GuDAcjVY5oQ2w0txdh8lv90sC60zUI7tl9PS2eAcj3qtSlrwxOou
hrIbk1aLPZAxon7sYE3LOHxomTA3JEAdYBAO/d8N+br9vb2L0o/zV+0cyffuHrWN
qSfe02EMV6J29W2qcuvAJrHjeLJ5AuuylTvUi0l/d4DtXxmYimscbRHnfGbv4F04
+Q3jtfmJEvxISbH0H5kjPo9z6K1u/ZMGF9O5121KbZi+9oybVpSNCyD4XJcKEYlV
oz6QFB4KYIP6Ao2eee6BqoC4jJ8F0XwwbIyj7n3s03KAAXdkq+Z2WzowH+OZTt9v
Q8g0krnKf+6rzcxcXBuEp0ft/ko92okms1H2x2ki2D33c3cFcJrSusw5cKP5Yczk
nClivcrZ6AFzcYpfN9Fe
=Sj9q
-----END PGP SIGNATURE-----

--3Gf/FFewwPeBMqCJ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111117023921.GB7628>