From owner-freebsd-arch@FreeBSD.ORG  Tue Jul  3 06:21:13 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@freebsd.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4805D16A400
	for <arch@freebsd.org>; Tue,  3 Jul 2007 06:21:13 +0000 (UTC)
	(envelope-from jroberson@chesapeake.net)
Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com
	[216.240.101.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 12A3713C45A
	for <arch@freebsd.org>; Tue,  3 Jul 2007 06:21:12 +0000 (UTC)
	(envelope-from jroberson@chesapeake.net)
Received: from [192.168.1.101] (c-71-231-138-78.hsd1.or.comcast.net
	[71.231.138.78]) (authenticated bits=0)
	by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id
	l636LAAN055926
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <arch@freebsd.org>; Tue, 3 Jul 2007 02:21:11 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Mon, 2 Jul 2007 23:20:48 -0700 (PDT)
From: Jeff Roberson <jroberson@chesapeake.net>
X-X-Sender: jroberson@10.0.0.1
To: arch@freebsd.org
Message-ID: <20070702230728.E552@10.0.0.1>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: 
Subject: Fine grain select locking.
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jul 2007 06:21:13 -0000

I have a diff which makes the following improvements to select:

1) Per-thread wait channel rather than global select wait channel.
2) Per-thread select lock.
3) Rescan after sleep scans only descriptors which have come active.
4) No exposed select internals.
5) selwakeuppri() works again.
6) No thread_lock()ing in select, no TDF_SELECT required.
7) No more collisions.

This is based on an approach from Alfred with some locking and rescan 
improvements by me.  It only required changing select users in cases where 
they assumed only one thread could select at a time.

The unfortunate cost of this patch is that a descriptor per select fd must 
be allocated to track individual threads.  This is what allows us to know 
which descriptor has fired an event and allows us to use per-thread 
locking etc.

The one thing I haven't fixed is netsmb and netncp which both have some 
wonky select implementation that could be replaced with kern_select(). 
That could be done seperately from this patch but is required for this to 
go in.

http://people.freebsd.org/~jeff/select.diff

Comments and suggestions welcome.

Thanks,
Jeff