From owner-freebsd-ports Tue Aug 15 10:34:21 2000 Delivered-To: freebsd-ports@freebsd.org Received: from xellos.bignet.net (xellos.bignet.net [64.79.64.6]) by hub.freebsd.org (Postfix) with ESMTP id 7B63537B7FD for ; Tue, 15 Aug 2000 10:34:15 -0700 (PDT) (envelope-from will@almanac.yi.org) Received: from argon.gryphonsoft.com (mcut-b-078.resnet.purdue.edu [128.211.209.78]) by xellos.bignet.net (8.9.3/8.9.3) with ESMTP id NAA32540; Tue, 15 Aug 2000 13:34:06 -0400 Received: by argon.gryphonsoft.com (Postfix, from userid 1000) id AEB5C1999; Tue, 15 Aug 2000 12:30:48 -0500 (EST) Date: Tue, 15 Aug 2000 13:30:48 -0400 From: Will Andrews To: James Housley Cc: freebsd-ports@FreeBSD.ORG Subject: Re: Indicating patch levels Message-ID: <20000815133048.B4306@argon.gryphonsoft.com> References: <399973A2.F3756F18@thehousleys.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <399973A2.F3756F18@thehousleys.net>; from jim@thehousleys.net on Tue, Aug 15, 2000 at 12:45:22PM -0400 X-Operating-System: FreeBSD 5.0-CURRENT i386 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, Aug 15, 2000 at 12:45:22PM -0400, James Housley wrote: > I have come up with some code that adds the patch level ONLY upon > request. > > .if defined(OARCORP) > PATCHLEVEL= 2 > .if defined(PKG_NOCOMPRESS) > PKG_SUFX?= -${PATCHLEVEL}.tar > .else > PKG_SUFX?= -${PATCHLEVEL}.tgz > .endif > .endif Patchlevels are just indicated as a minor version bump. I.e., if previous version was 1.6.3, and you now have patchlevel 1.6.3-2, we indicate that with "1.6.3.2". Hence: PORTVERSION= 1.6.3.2 [..] DISTNAME= 1.6.3-2 The fact that Linux folks use hyphens to indicate patchlevels is broken behavior, IMHO... > I add this to my Makefiles. Currently I am working on the newest > versions of these ports. Will this code cause it to be shot down? Yes. Please use the above behavior, which is perfectly fine.. -- Will Andrews GCS/E/S @d- s+:+ a--- C++ UB++++$ P+ L- E--- W+ N-- !o ?K w--- O- M+ V- PS+ PE++ Y+ PGP+>+++ t++ 5 X+ R+ tv+ b++ DI+++ D+ G++ e>++++ h! r- y? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message