From owner-freebsd-current@FreeBSD.ORG Tue Jul 28 20:59:58 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 486D810656B4; Tue, 28 Jul 2009 20:59:58 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id A4B0E8FC22; Tue, 28 Jul 2009 20:59:57 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: by bwz12 with SMTP id 12so223967bwz.43 for ; Tue, 28 Jul 2009 13:59:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.173.15 with SMTP id a15mr4199851mup.59.1248814796635; Tue, 28 Jul 2009 13:59:56 -0700 (PDT) In-Reply-To: <4A6F5A1F.2070906@omnilan.de> References: <4A5CB2D1.5070106@omnilan.de> <4A5CC981.8010000@omnilan.de> <4A5EDA14.8000703@omnilan.de> <4A5F0F4F.5060505@andric.com> <4A6F52BE.9000901@omnilan.de> <9bbcef730907281255u3f426923g886893585899d210@mail.gmail.com> <4A6F5A1F.2070906@omnilan.de> Date: Tue, 28 Jul 2009 22:59:56 +0200 Message-ID: From: =?ISO-8859-1?Q?Marius_N=FCnnerich?= To: Harald Schmalzbauer Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Dimitry Andric , freebsd-current@freebsd.org, Ivan Voras Subject: Re: gmirror provider name limit [Was: Re: geom_label: gpt/labelname for gmirror provider?] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 20:59:58 -0000 On Tue, Jul 28, 2009 at 22:05, Harald Schmalzbauer wrote: > Ivan Voras schrieb am 28.07.2009 21:55 (localtime): > ... >>>> >>>> sys/geom/stripe/g_stripe.h:91: =A0char =A0 =A0 =A0 =A0 =A0 =A0md_provi= der[16]; /* >>>> Hardcoded provider. */ >>> >>> Are there any problems to expect when extending the array size? >> >> If you mean the char array of the provider name then yes, it cannot be >> done without introducing a new metadata version (and then if it fits). > > Oic, thanks for the hint. I forogt about the metadata... *slap* > >>> To make use og gptid it had to be 43. >> >> I don't follow you on this - why gptid and why 43? > > The automatically generated gptid is 36 cahracters plus "gptid/" to use t= hat > for a provider name. In my case I'd like to assign the following label: > fbsd8GUNE-root_RAID1prov.1of2 > It's 30 characters, so I thought using the gptid length was a feasible > limit... The current size of the gmirror metadata is 135 bytes so a providername of 64 would easily fit but I'm not sure it's worth the hassle. Maybe one could include it if/when there is a new version. Anyway till then it should be documented and there should be an error message from the utils which create the mirror (and the other setups).