From owner-cvs-src@FreeBSD.ORG Thu Jul 26 18:38:20 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD11E16A417; Thu, 26 Jul 2007 18:38:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 71A5613C480; Thu, 26 Jul 2007 18:38:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.7b8) with ESMTP id 199171049 for multiple; Thu, 26 Jul 2007 14:46:55 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l6QIbvUw030369; Thu, 26 Jul 2007 14:37:58 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Pawel Jakub Dawidek Date: Thu, 26 Jul 2007 14:18:58 -0400 User-Agent: KMail/1.9.6 References: <200707261658.l6QGwAs8038591@repoman.freebsd.org> In-Reply-To: <200707261658.l6QGwAs8038591@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707261418.59436.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 26 Jul 2007 14:37:58 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3778/Thu Jul 26 13:57:13 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2007 18:38:21 -0000 On Thursday 26 July 2007 12:58:10 pm Pawel Jakub Dawidek wrote: > pjd 2007-07-26 16:58:09 UTC > > FreeBSD src repository > > Modified files: > sys/fs/devfs devfs_vnops.c > sys/fs/fifofs fifo_vnops.c > sys/kern uipc_usrreq.c vfs_vnops.c > sys/vm vnode_pager.c > Log: > When we do open, we should lock the vnode exclusively. This fixes few races: > - fifo race, where two threads assign v_fifoinfo, > - v_writecount modifications, > - v_object modifications, > - and probably more... Is it possible this could fix some 'vrele: negative ref cnt' and 'vput: negative ref cnt' panics I am seeing on 6.x? e.g.: panic: vput: negative ref cnt cpuid = 3 KDB: stack backtrace: kdb_backtrace() at kdb_backtrace+0x37 panic() at panic+0x1d3 vput() at vput+0xd1 vn_close() at vn_close+0x7d vn_closefile() at vn_closefile+0x10a fdrop_locked() at fdrop_locked+0x10d fdrop() at fdrop and: panic: vrele: negative ref cnt cpuid = 3 KDB: stack backtrace: kdb_backtrace() at kdb_backtrace+0x37 panic() at panic+0x1d1 vrele() at vrele+0xe1 vm_object_vndeallocate() at vm_object_vndeallocate+0x68 vm_object_deallocate() at vm_object_deallocate+0xe9 vm_map_entry_delete() at vm_map_entry_delete+0x17e vm_map_delete() at vm_map_delete+0x20e vmspace_exit() at vmspace_exit+0xe1 exit1() at exit1+0x67a sys_exit() at sys_exit+0xe syscall() at syscall+0x404 -- John Baldwin