Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 02 Apr 2001 11:34:11 -0800 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Doug Rabson <dfr@nlsystems.com>
Cc:        mjacob@feral.com, freebsd-alpha@FreeBSD.org, Michael Richards <michael@fastmail.ca>, Mike Smith <msmith@FreeBSD.org>
Subject:   Re: Proposed Loader fix
Message-ID:  <XFMail.010402113411.jhb@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.33.0104021125160.5113-100000@herring.nlsystems.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On 02-Apr-01 Doug Rabson wrote:
> On Mon, 2 Apr 2001, Mike Smith wrote:
> 
>> > My proposed solution is:
>> > Modify the devsw struct. Here is the original:
>> ...
>> > This appears to carry info about the device. So I say that I should
>> > be able to add a flag to it so it will not be opened multiple times.
>>
>> Don't do this.  Try adding some caching to libalpha so that it doesn't
>> open the prom device more than once.  Since we only need one handle (SRM
>> doesn't support more than one device), once we've got one, we can always
>> reuse it.
> 
> How about something like this (untested) patch. I'm not entirely happy
> with it since it will never call prom_close and I remember having problems
> with ncr hardware not probing properly if we didn't close it in the
> loader. Possibly an 'open count' or similar would suffice.

It would be better I think since prom_close() would get called eventually.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010402113411.jhb>