From owner-svn-ports-all@freebsd.org Fri Aug 31 12:41:21 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 475EAF7F884; Fri, 31 Aug 2018 12:41:21 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EDFC970EDD; Fri, 31 Aug 2018 12:41:20 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id E5D1E1CFBA; Fri, 31 Aug 2018 12:41:20 +0000 (UTC) Date: Fri, 31 Aug 2018 12:41:20 +0000 From: Alexey Dokuchaev To: Tobias Kortkamp Cc: ndowens@yahoo.com, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r478529 - in head: audio/atunes devel/efl graphics/gimageview graphics/opencv graphics/osg graphics/osg-devel multimedia/gxine multimedia/k9copy-kde4 multimedia/libxine multimedia/libxi... Message-ID: <20180831124120.GA26782@FreeBSD.org> References: <201808310816.w7V8GIhm033801@repo.freebsd.org> <20180831101627.GA93235@FreeBSD.org> <1535714662.2255182.1492419576.2BB150A3@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1535714662.2255182.1492419576.2BB150A3@webmail.messagingengine.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 12:41:21 -0000 On Fri, Aug 31, 2018 at 01:24:22PM +0200, Tobias Kortkamp wrote: > On Fri, Aug 31, 2018, at 12:16, Alexey Dokuchaev wrote: > > On Fri, Aug 31, 2018 at 08:16:18AM +0000, Tobias Kortkamp wrote: > > > New Revision: 478529 > > > URL: https://svnweb.freebsd.org/changeset/ports/478529 > > > > > > Log: > > > multimedia/libxine: Update to 1.2.9 > > > > > > - Cleanup options > > > - Enable IMAGEMAGICK by default > > > > Can you elaborate more on this one? IM is a rather heavy dependency, esp. > > with default selection of options, and I'm surprized why it would be needed > > by default in the multimedia decoding library. > > Please qualify "heavy dependency". Just have a look at its USES and dependencies: % make -V USES cpe gettext-runtime gmake gnome libtool:keepla localbase pathfix perl5 pkgconfig:both shebangfix tar:xz jpeg ghostscript:x11 % make -V LIB_DEPENDS libltdl.so:devel/libltdl libraw_r.so:graphics/libraw liblcms2.so:graphics/lcms2 libpng.so:graphics/png libtiff.so:graphics/tiff liblqr-1.so:graphics/liblqr-1 libfftw3.so:math/fftw3 libjbig.so:graphics/jbigkit libopenjp2.so:graphics/openjpeg liblcms2.so:graphics/lcms2 libfreetype.so:print/freetype2 libwebp.so:graphics/webp libfontconfig.so:x11-fonts/fontconfig libwmf.so:graphics/libwmf librsvg-2.so:graphics/librsvg2 libintl.so:devel/gettext-runtime libcairo.so:graphics/cairo libgdk_pixbuf-2.0.so:graphics/gdk-pixbuf2 libglib-2.0.so:devel/glib20 libintl.so:devel/gettext-runtime libxml2.so:textproc/libxml2 libjpeg.so:graphics/jpeg-tur > I haven't really questioned it. As committers, we should question every non-obvious, let alone dubious, change proposed. ./danfe