Date: Sat, 13 Oct 2012 15:13:04 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Pawel Pekala <pawel@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305793 - in head/emulators: . swine Message-ID: <201210131513.04741.makc@freebsd.org> In-Reply-To: <201210122156.q9CLuA9X082810@svn.freebsd.org> References: <201210122156.q9CLuA9X082810@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Pawel,
On Fri, 12 Oct 2012 21:56:10 +0000 (UTC)Fri Oct 12 21:56:09 2012, Pawel Pekala wrote:
> Added: head/emulators/swine/Makefile
> ==============================================================================
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ head/emulators/swine/Makefile Fri Oct 12 21:56:09 2012 (r305793)
> @@ -0,0 +1,83 @@
> +# Created by: nemysis@gmx.ch
> +# $FreeBSD$
> +
> +PORTNAME= swine
> +PORTVERSION= 1.0.2
> +CATEGORIES= emulators deskutils python
> +MASTER_SITES= GH
> +
> +MAINTAINER= nemysis@gmx.ch
> +COMMENT= QT4 Graphical Wine frontend
> +
> +LICENSE= GPLv2
> +
> +BUILD_DEPENDS= pyrcc4:${PORTSDIR}/textproc/py-qt4-xml
> +RUN_DEPENDS= wine:${PORTSDIR}/emulators/wine-devel \
> + xterm:${PORTSDIR}/x11/xterm \
> + cabextract:${PORTSDIR}/archivers/cabextract \
> + icotool:${PORTSDIR}/graphics/icoutils \
> + ${PYTHON_PKGNAMEPREFIX}qt4-core>=${PYQT4_VERSION}:${PORTSDIR}/devel/py-qt4-core \
> + ${PYTHON_PKGNAMEPREFIX}qt4-gui>=${PYQT4_VERSION}:${PORTSDIR}/x11-toolkits/py-qt4-gui
py-qt4-gui depends on py-qt4-core, the latter can be omitted from RUN_DEPENDS.
Besides, ports shouldn't request py-qt4 packages newer or equal
${PYQT4_VERSION}, either check for minimum required version, or use usual
dependency specification, e.g.
${PYTHON_SITELIBDIR}/PyQt4/QtGui.so:${PORTSDIR}/x11-toolkits/py-qt4-gui
> +DATADIRLIB= ${PREFIX}/lib/${PORTNAME}
> +
> +USE_GITHUB= yes
> +GH_ACCOUNT= dswd
> +GH_PROJECT= Swine
> +GH_TAGNAME= master
> +GH_COMMIT= d14b9f0
> +
> +USE_PYTHON= yes
> +USE_GMAKE= yes
> +USE_QT4= linguist_build
> +
> +PORTDOCS= README
> +
> +.include "../../devel/py-sip/files/bsd.pyqt.mk"
You don't need to include this file, once you fix RUN_DEPENDS.
> +pre-build:
> +.if !exists(${LOCALBASE}/bin/wine) && ${ARCH} != "i386"
> + @${ECHO_MSG}
> + @${ECHO_MSG} "Depends on Wine Port which is only available for i386"
> + @${ECHO_MSG}
> + @${ECHO_MSG} " http://wiki.freebsd.org/Wine"
> + @${ECHO_MSG}
> + @${ECHO_MSG} "FreeBSD/amd64 works with Wine 32bit binary from"
> + @${ECHO_MSG}
> + @${ECHO_MSG} " http://www.mediafire.com/wine_fbsd64"
> + @${ECHO_MSG}
> + exit 1
> +.endif
Those who use only packages will never see this notice. Please move it to
pkg-message.
> +do-build:
> + @(cd ${WRKSRC} ; ${GMAKE})
The port already has USE_GMAKE, why do you need custom do-build and do-install
targets?
> +do-install:
> + ${MKDIR} ${DATADIRLIB}
> + ${INSTALL_DATA} ${WRKSRC}/resources.qrc ${DATADIRLIB}
> + ${INSTALL_SCRIPT} ${WRKSRC}/*.py ${DATADIRLIB}
> + ${LN} -sf ${DATADIRLIB}/${PORTNAME}.py ${PREFIX}/bin/${PORTNAME}
> + ${LN} -sf ${DATADIRLIB}/${PORTNAME}cli.py ${PREFIX}/bin/${PORTNAME}cli
> + ${LN} -sf ${DATADIRLIB}/${PORTNAME}run.py ${PREFIX}/bin/${PORTNAME}run
> + ${MKDIR} ${DATADIR}
> + @(cd ${WRKSRC} && ${COPYTREE_SHARE} "translations images" ${DATADIR})
> +
> + ${LN} -sf ${DATADIR}/images/swine32.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
> + ${MKDIR} ${PREFIX}/share/applications
> + ${INSTALL_DATA} ${WRKSRC}/resources/*.desktop ${PREFIX}/share/applications/
> +
> +.if ${PORT_OPTIONS:MDOCS}
> + ${MKDIR} ${DOCSDIR}
> + ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
> +.endif
> +
> + @${ECHO_CMD}
> + @${CAT} ${PKGMESSAGE}
> + @${ECHO_CMD}
> +
> +.include <bsd.port.mk>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210131513.04741.makc>