From owner-freebsd-bugs Tue Jul 3 1:47:18 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id CB23B37B401; Tue, 3 Jul 2001 01:47:14 -0700 (PDT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 3 Jul 2001 09:47:14 +0100 (BST) To: Ruslan Ermilov Cc: Andy , David Malone , bug-followup@FreeBSD.org, bugs@FreeBSD.org Subject: Re: bin/28634: Bug in syslogd.c prevents #+hostname working In-reply-to: Your message of "Tue, 03 Jul 2001 11:42:24 +0300." <20010703114224.B6517@sunbay.com> X-Request-Do: Date: Tue, 03 Jul 2001 09:47:14 +0100 From: David Malone Message-ID: <200107030947.aa33361@salmon.maths.tcd.ie> Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org > Works nice here without your patch, modulo the bug David mentioned. > If the sending host is within the same domain, using FQDN for the > sending host does not work, unless the following patch is applied. > I must admit I don't like how the ``#+'' is currently implemented. > For example, it is unclear (and undocumented) from the reading > of the manpage, that the -n flag affects the hostname specification > in syslog.conf(5). Yep - I think this could all be documented better in the man page. I think the "-n" flag and the host selection stuff were added about the same time and the man page was never updated to take account of the interaction. The patch you included would be a reasonable fix, but I think it may be better to keep the full host name within syslogd until the log message is written to the log. This is because syslogd trys to reconstruct the full host name in atleasy one place after it has truncated it, which seems silly. David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message