Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Dec 2019 19:25:57 +0000
From:      bugzilla-noreply@freebsd.org
To:        vbox@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 242637] [patch] emulators/virtualbox-ose: fix bridging when the ng_ether node name does not match the interface name
Message-ID:  <bug-242637-26505-u7azhvuTET@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-242637-26505@https.bugs.freebsd.org/bugzilla/>
References:  <bug-242637-26505@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help

Bugzilla Automation <bugzilla@FreeBSD.org> has asked vbox@FreeBSD.org for
maintainer-feedback:
Bug 242637: [patch] emulators/virtualbox-ose: fix bridging when the ng_ether
node name does not match the interface name
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242637



--- Description ---
This patch fixes bridging in cases where the interface's ng_ether netgraph node
name does not match its interface name.

This is commonly seen with VLANs configured in rc.conf; for example:

  ifconfig_igb0="up"
  vlans_igb0="12"

This will create an 'igb0.12' VLAN interface, but because '.' is a reserved
character in netgraph node names, the corresponding netgraph node will be named
'igb0_12':

    Name: igb0_12	  Type: ether		ID: 00000007   Num hooks: 0

Currently, VBoxNetFlt assumes a 1:1 correspondence between interface name and
ng_ether node name; when attempting to bridge to igb0.12, the node named
"igb0.12" is not found, and VBoxNetFlt's netgraph initialization silently
fails.

Rather than assume the node name, this patch enumerates all ng_ether nodes,
using the NGM_ETHER_GET_IFNAME control message to identify the ng_ether node
corresponding to the target interface.

I've attached patches for the current emulators/virtualbox-ose port, as well as
a patch relative to the 6.1 patch posted on 2019-12-13
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878).



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242637-26505-u7azhvuTET>