From owner-freebsd-hackers@FreeBSD.ORG Thu Aug 7 22:33:28 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6526F1065675 for ; Thu, 7 Aug 2008 22:33:28 +0000 (UTC) (envelope-from andenore@freebsd.org) Received: from smtp.bluecom.no (smtp.bluecom.no [193.75.75.28]) by mx1.freebsd.org (Postfix) with ESMTP id ECDD08FC12 for ; Thu, 7 Aug 2008 22:33:27 +0000 (UTC) (envelope-from andenore@freebsd.org) Received: from duckjen.nextgentel.no (cFC4401C3.dhcp.bluecom.no [195.1.68.252]) by smtp.bluecom.no (Postfix) with ESMTP id 34C7310D76AF; Fri, 8 Aug 2008 00:31:07 +0200 (CEST) Date: Fri, 08 Aug 2008 00:30:16 +0200 To: "Lars Engels" From: "Anders Nore" Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8 MIME-Version: 1.0 References: <1234BBCE-6698-4EF9-8B48-4F291AD78547@freebsd.org> <20080807204035.GT56464@e.0x20.net> Content-Transfer-Encoding: 7bit Message-ID: In-Reply-To: <20080807204035.GT56464@e.0x20.net> User-Agent: Opera Mail/9.50 (FreeBSD) Cc: "freebsd-hackers@freebsd.org" Subject: Re: Suggestion for 'pkg_add -r' X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2008 22:33:28 -0000 On Thu, 07 Aug 2008 22:40:35 +0200, Lars Engels wrote: > On Thu, Aug 07, 2008 at 03:47:24PM +0200, Anders Nore wrote: >> >> >> >>RELENG_7: >> >>http://home.no.net/andenore/patches/pkg_install_2008-08-06_RELENG_7.diff >> >> >> >>CURRENT: >> >>http://home.no.net/andenore/patches/pkg_install_2008-08-06_CURRENT.diff >> > >> >Some comments: >> > * I think you have reversed the patch. :-) >> > * Build errors: >> >cc1: warnings being treated as errors >> >file.c:433: warning: no previous prototype for 'power' >> >file.c:452: warning: no previous prototype for 'human_readable' >> >file.c:474: warning: no previous prototype for 'printHumanReadable' >> >file.c: In function 'printHumanReadable': >> >file.c:482: warning: comparison between signed and unsigned >> > >> >parallels# ./pkg_add -r joe >> >Fetching 321.2 kB from >> >ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-8-current/Latest/joe.tbz... >> > Downloading: 100% 321.2 kB at >> 214.8 kB/s >> > Done >> >Fetching 2.4 MB from >> >ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-8-current/All/gettext-0.17_1.tbz... >> > >> Done >> >Fetching 2.2 MB from >> >ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-8-current/All/aspell-0.60.6_2.tbz... >> > Downloading: 201% 4.5 MB at >> 149.5 kB/s >> > >> >Something's wrong :-) >> > >> >> Heh, yes. It's my first patch(es), so it didn't go as well as I had >> hoped, I believe they are >> fixed now. > > I just downloaded the patch and still get the warning: > /usr/src/usr.sbin/pkg_install/lib/file.c: In function > 'printHumanReadable': > /usr/src/usr.sbin/pkg_install/lib/file.c:486: warning: comparison > between signed and unsigned > *** Error code 1 > > Stop in /usr/src/usr.sbin/pkg_install/lib. > Hey, it should be fixed now. I don't know why this causes a stop in the compiling though? Thanks, Anders Nore