From owner-freebsd-hackers@FreeBSD.ORG Sat Aug 23 06:43:59 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B531E106566C for ; Sat, 23 Aug 2008 06:43:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 768E58FC15 for ; Sat, 23 Aug 2008 06:43:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m7N6fbor087330; Sat, 23 Aug 2008 00:41:37 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 23 Aug 2008 00:42:09 -0600 (MDT) Message-Id: <20080823.004209.1974818375.imp@bsdimp.com> To: max@love2party.net From: "M. Warner Losh" In-Reply-To: <200808212351.13464.max@love2party.net> References: <200808212351.13464.max@love2party.net> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@freebsd.org Subject: Re: MFC of r180753: ABI problems? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2008 06:43:59 -0000 In message: <200808212351.13464.max@love2party.net> Max Laier writes: : Hi, : : I'm wondering how to merge r180753 to stable/7 as luoqi@ has indicated that he : doesn't have time to take care of it right now. : : It seems that changing the size of pcicfgregs (aka struct pcicfg) which is : part of struct pci_devinfo is out of the question, right? Ideas where to : store the HT related state or how to avoid storing the state are welcome. : : The merge result is attached for reference. This fix is essential for many : nforce based boards from ASUS which are rather common, I'm afraid. So it : would be good to have this in 7.1/6.4, I think. I think this is OK. pcicfgregs is an internal to pci implementation detail. You've added it at the end, so any leakage of the offsets won't matter. All subclasses of pci would be affected. Internal to the kernel isn't all that interesting, since they are all compiled at the same time. This would only matter for modules. Cardbus and acpi would be the only modules affected. That would mean you couldn't boot a 7.0 kernel with a 7.1 set of modules or vice versa. I'm not sure that is actually going to work anyway... Warner