From owner-freebsd-acpi@FreeBSD.ORG  Mon Aug 16 18:35:36 2004
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 73FC916A4CE; Mon, 16 Aug 2004 18:35:36 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2725443D55; Mon, 16 Aug 2004 18:35:36 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i7GIXY81082167;
	Mon, 16 Aug 2004 14:33:34 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i7GIXUad082164;
	Mon, 16 Aug 2004 14:33:34 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Mon, 16 Aug 2004 14:33:30 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Nate Lawson <nate@root.org>
In-Reply-To: <4120F26B.1040808@root.org>
Message-ID: <Pine.NEB.3.96L.1040816143239.82126A-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Stefan Farfeleder <stefan@fafoe.narf.at>
cc: acpi@freebsd.org
cc: current@freebsd.org
Subject: Re: HEADSUP: acpi mpsafe committed
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Aug 2004 18:35:36 -0000


On Mon, 16 Aug 2004, Nate Lawson wrote:

> Stefan Farfeleder wrote:
> > On Thu, Aug 12, 2004 at 11:35:48PM -0700, Nate Lawson wrote:
> > 
> >>Let me know if there are any problems.
> > 
> > 
> > I'm now getting a panic if I want to suspend my Thinkpad R32 via Fn-F4
> > (manually transcribed):
> > 
> > panic: mutex Giant not owned at /usr/src/sys/net/if.c:1874
> > 
> > db> trace
> > kdb_enter
> > panic
> > _mtx_assert
> > if_start
> > ieee80211_mgmt_output
> > ieee80211_send_mgmt
> > ieee80211_newstate

wi_newstate() should probably call NET_LOCK_GIANT() before entering the
802.11 framework, and call NET_UNLOCK_GIANT() on its return.  This will
cause it to conditionally acquire and release Giant based on
debug_mpsafenet. 

> I can't see how the acpi commit affects this.  The assertion is in the
> if code so it's likely that wi(4) is not setting the right flag to
> acquire Giant before if_start. 

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Principal Research Scientist, McAfee Research