Date: Wed, 30 Nov 2005 23:57:43 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 87554 for review Message-ID: <200511302357.jAUNvhm7080252@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=87554 Change 87554 by rwatson@rwatson_peppercorn on 2005/11/30 23:57:14 Annotate a case of non-atomicity in the BSM flags code, where there is a potential race with another thread in similar code. Affected files ... .. //depot/projects/trustedbsd/openbsm/libbsm/bsm_flags.c#7 edit Differences ... ==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_flags.c#7 (text+ko) ==== @@ -97,6 +97,11 @@ * * XXXRW: If bits are specified that are not matched by any class, they are * omitted rather than rejected with EINVAL. + * + * XXXRW: This is not thread-safe as it relies on atomicity between + * setauclass() and sequential calls to getauclassent(). This could be + * fixed by iterating through the bitmask fields rather than iterating + * through the classes. */ int getauditflagschar(char *auditstr, au_mask_t *masks, int verbose)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511302357.jAUNvhm7080252>