From owner-p4-projects@FreeBSD.ORG  Fri Nov 20 08:45:27 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4023010656AA; Fri, 20 Nov 2009 08:45:27 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D9E85106566B
	for <perforce@freebsd.org>; Fri, 20 Nov 2009 08:45:26 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
Received: from swip.net (mailfe03.swip.net [212.247.154.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 686C28FC0A
	for <perforce@freebsd.org>; Fri, 20 Nov 2009 08:45:26 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=IUOrzmqebuoA:10
	a=RERtC8nhXGhYvIZhK0yWrQ==:17 a=6I5d2MoRAAAA:8
	a=sF_zMzOa3JytTgiJurUA:9 a=N-ghdWLVBQ_JKSUbk4QA:7
	a=vb905cmgOYz1UhKj2V17596r9EAA:4
Received: from [90.149.203.35] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.16)
	with ESMTPA id 1348168802; Fri, 20 Nov 2009 08:45:23 +0100
Received-SPF: softfail receiver=mailfe03.swip.net; client-ip=90.149.203.35;
	envelope-from=hselasky@freebsd.org
From: Hans Petter Selasky <hselasky@freebsd.org>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Date: Fri, 20 Nov 2009 08:46:48 +0100
User-Agent: KMail/1.11.4 (FreeBSD/9.0-CURRENT; KDE/4.2.4; i386; ; )
References: <200911192235.nAJMZ2XH072195@repoman.freebsd.org>
	<4B05CB1F.8020100@freebsd.org>
In-Reply-To: <4B05CB1F.8020100@freebsd.org>
X-Face: (%<A9p'; 5>:6u[ldzJ`0qjD7sCkfdMmD*RxpO<Q0yAl~?`'F?jDVb]E6TQ7'#h-VlLs}k/
	(yxg(p!IL.`#ng"%`BMrham7%UK,}VH\wUOm=^>wEEQ+KWt[{J#x6ow~JO:,zwp.(t; @Aq
	:4:&nFCgDb8[3oIeTb^'",;u{5{}C9>"PuY\)!=#\u9SSM-nz8+SR~B\!qBv
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200911200846.54559.hselasky@freebsd.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 170842 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2009 08:45:28 -0000

On Thursday 19 November 2009 23:47:59 Nathan Whitehorn wrote:
> Hans Petter Selasky wrote:
> > http://p4web.freebsd.org/chv.cgi?CH=170842
> >
> > Change 170842 by hselasky@hselasky_laptop001 on 2009/11/19 22:34:49
> >
> >
> > 	USB input:
> > 		 - ATP patch from Rohit Grover:
> > 		   - fixes some minor issues and
> > 		     makes the control transfer
> > 		     fully asynchronous
>
> [...]
>
> > @@ -1530,7 +1574,7 @@
> >  		return (ENXIO);
> >
> >  	if (usbd_lookup_id_by_uaa(atp_devs, sizeof(atp_devs), uaa) == 0)
> > -		return BUS_PROBE_SPECIFIC;
> > +		return 0;
> >  	else
> >  		return ENXIO;
> >  }
>
> Why are you replacing symbolic constants with less informative numeric
> ones? -Nathan

Because returning zero in probe has special meaning and is hardcoded in the 
subr_bus.c code aswell. The other return values will not be changed.

--HPS