Date: Mon, 19 Dec 2016 20:02:42 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Ravi Pokala <rpokala@mac.com>, Sepherosa Ziehau <sepherosa@gmail.com>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r310171 - head/sys/sys Message-ID: <0C6B935C-496B-4EF4-963F-95286CBA45BA@FreeBSD.org> In-Reply-To: <CANCZdfoN_NNsU2bW2mvLifSCoNhYj-XNvNYLosMsbmnbG9JfYQ@mail.gmail.com> References: <201612161949.uBGJnMol059217@repo.freebsd.org> <CAMOc5cw8cBUN5UZjcRJ-vM5WE0vmD2AGDZ-raKTraFz7LBR2hg@mail.gmail.com> <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> <CANCZdfoN_NNsU2bW2mvLifSCoNhYj-XNvNYLosMsbmnbG9JfYQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D7AC963E-59B0-4A18-8480-32507CCD267D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 19 Dec 2016, at 19:58, Warner Losh <imp@bsdimp.com> wrote: >=20 > On Mon, Dec 19, 2016 at 1:39 AM, Ravi Pokala <rpokala@mac.com> wrote: >> -----Original Message----- >>> From: <owner-src-committers@freebsd.org> on behalf of Sepherosa = Ziehau <sepherosa@gmail.com> >>> Date: 2016-12-18, Sunday at 23:02 >>> To: Dimitry Andric <dim@freebsd.org> >>> Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, = <svn-src-head@freebsd.org> >>> Subject: Re: svn commit: r310171 - head/sys/sys >>>=20 >>> The following patch unbreaks the LINT builds on amd64 for me after = this commit: >>> https://people.freebsd.org/~sephe/geom_sscanf.diff >>=20 >> Wouldn't it be better to use the SCN macros? >=20 > Are there other precedence for avoiding the SCN macros in the tree as > well, or is this new art? I personally don't have anything against using the PRI or SCN macros, but traditionally there has been some backlash against it, if I recall correctly. It also requires including either <machine/_inttypes.h> or <inttypes.h>, depending on circumstance or preference. -Dimitry --Apple-Mail=_D7AC963E-59B0-4A18-8480-32507CCD267D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhYLtoACgkQsF6jCi4glqMQSQCgh5lW/6sUOUx9BCZdXXCtkqaI hLQAnRonSXarpfNVM5K65bvhxOQji+2j =yv1T -----END PGP SIGNATURE----- --Apple-Mail=_D7AC963E-59B0-4A18-8480-32507CCD267D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0C6B935C-496B-4EF4-963F-95286CBA45BA>