Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jan 2011 00:29:17 +0000 (UTC)
From:      Lawrence Stewart <lstewart@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r217248 - head/sys/kern
Message-ID:  <201101110029.p0B0THRK000382@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: lstewart
Date: Tue Jan 11 00:29:17 2011
New Revision: 217248
URL: http://svn.freebsd.org/changeset/base/217248

Log:
  Fix some minor style/readability nits in hhook.
  
  Sponsored by:	FreeBSD Foundation
  Submitted by:	pjd
  MFC after:	9 weeks
  X-MFC with:	r216615

Modified:
  head/sys/kern/kern_hhook.c

Modified: head/sys/kern/kern_hhook.c
==============================================================================
--- head/sys/kern/kern_hhook.c	Mon Jan 10 23:47:11 2011	(r217247)
+++ head/sys/kern/kern_hhook.c	Tue Jan 11 00:29:17 2011	(r217248)
@@ -156,8 +156,7 @@ hhook_add_hook(struct hhook_head *hhh, s
 	if (!error) {
 		STAILQ_INSERT_TAIL(&hhh->hhh_hooks, hhk, hhk_next);
 		hhh->hhh_nhooks++;
-	}
-	else
+	} else
 		free(hhk, M_HHOOK);
 
 	HHH_WUNLOCK(hhh);
@@ -332,7 +331,6 @@ hhook_head_deregister_lookup(int32_t hho
 	struct hhook_head *hhh;
 	int error;
 
-	error = 0;
 	hhh = hhook_head_get(hhook_type, hhook_id);
 	error = hhook_head_deregister(hhh);
 
@@ -356,13 +354,12 @@ hhook_head_get(int32_t hhook_type, int32
 	LIST_FOREACH(hhh, &V_hhook_head_list, hhh_next) {
 		if (hhh->hhh_type == hhook_type && hhh->hhh_id == hhook_id) {
 			refcount_acquire(&hhh->hhh_refcount);
-			HHHLIST_UNLOCK();
-			return (hhh);
+			break;
 		}
 	}
 	HHHLIST_UNLOCK();
 
-	return (NULL);
+	return (hhh);
 }
 
 void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101110029.p0B0THRK000382>