From owner-freebsd-commit Fri Apr 21 09:07:22 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA10287 for commit-outgoing; Fri, 21 Apr 1995 09:07:22 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA10274 for cvs-sys-outgoing; Fri, 21 Apr 1995 09:07:19 -0700 Received: (from bde@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA10264 ; Fri, 21 Apr 1995 09:07:14 -0700 Date: Fri, 21 Apr 1995 09:07:14 -0700 From: Bruce Evans Message-Id: <199504211607.JAA10264@freefall.cdrom.com> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/boot/biosboot boot.h Sender: commit-owner@FreeBSD.org Precedence: bulk bde 95/04/21 09:07:14 Modified: sys/i386/boot/biosboot boot.h Log: Never pass char or short args to functions. This saves 64 bytes of recently introduced bloat in just 2 calls to biosread(), although very little in calls to putc() and serial_putc(). Gcc produces amazingly bad code for unnecessary conversions. E.g., if it has `int x' in register %edx and wants to pass a char, then it could simply push %edx and access only one byte in the callee. Instead, it sometimes unnecessarily spills %edx; it always sign extends %edx and pushes the result. Remove useless `extern' in function prototypes. Remove unused declaration of `end'. Declare pbzero() and pcpy() like the library bzero and bcopy(). Declare printf() properly.