Date: Wed, 30 Oct 2013 22:23:25 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Rusmir Dusko <nemysis@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332117 - head/graphics/py-pyglet Message-ID: <20131030182325.GF96134@hades.panopticon> In-Reply-To: <20131030171934.GA1124@nemysis4now> References: <20131030171934.GA1124@nemysis4now>
next in thread | previous in thread | raw e-mail | index | archive | help
* Rusmir Dusko (nemysis@FreeBSD.org) wrote: > > +OPTIONS_DEFINE=DOCS EXAMPLES > > +OPTIONS_DEFAULT=DOCS EXAMPLES > > As per my understanding you wrecked OPTIONS_DEFAULTS, > please take a look at > > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html and > > 5.12.2.3. Default Options True. Will axe these unneeded defaults in a single go a bit later. > This is incorrect as well > > .if ${ARCH} != "i386" > IGNORE= crashes or doesn't work on !i386 > .endif This is perfectly correct, pyglet still segfaults on my amd64. > Please take a look at > > http://pyglet.org/ > > pyglet 1.2 alpha released. The major 1.2alpha1 release brings pyglet to Python 3. > Pyglet now also runs on 64-bit operating systems Linux, Windows and OS X. > The OS X layer switched to using Cocoa. There's also a load of bug fixes, > updates to the OpenGL wrappers and other minor new improvements. > Thanks to the pyglet community for all your effort in getting this release out. And this has nothing to do with 1.1.4 we have in ports. It'd be nice to update the port to 1.2alpha, but at least gondola doesn't work with it (haven't dig it deep yet, though). > Secondly, I dont think this is required > > .include <bsd.port.options.mk> This is required for ${ARCH}. > cd ${WRKSRC}/doc && ${COPYTREE_SHARE} \* ${STAGEDIR}${DOCSDIR}/ > cd ${WRKSRC}/examples && ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR}/ > > Better is to use > > @(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR}) > @(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR}) True. > Please take better look at ports/182517. I haven't closed it yet. I'm considering demos installation, but for that I need to set up i386 desktop in a virtualbox, to test it as pyglet doesn't work on amd64. But these should really be worth the complexity they add to the port. Sorry for the rollback anyway, but I'd really appreciate a headsup next time - whole-port conflicts when I'm working on several dozens of other ports are what I don't want. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131030182325.GF96134>