From owner-freebsd-fs@FreeBSD.ORG  Thu Oct 16 21:39:50 2014
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8820C899;
 Thu, 16 Oct 2014 21:39:50 +0000 (UTC)
Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca
 [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 399B635E;
 Thu, 16 Oct 2014 21:39:49 +0000 (UTC)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AqQEAEg6QFSDaFve/2dsb2JhbABbg2FcgwLJHodNAoErAX2EAwEBBCNWGxgCAg0ZAiM2GYgqAxENtnSOQQ2GQgEBAQEBBQEBAQEBARyBLIxtgWYaNAcWgmGBVAWWRYUBg0GOFoJYg36EEyEvgUiBAgEBAQ
X-IronPort-AV: E=Sophos;i="5.04,734,1406606400"; d="scan'208";a="161812584"
Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca)
 ([131.104.91.222])
 by esa-annu.net.uoguelph.ca with ESMTP; 16 Oct 2014 17:39:48 -0400
Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1])
 by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 7CE36B3EE4;
 Thu, 16 Oct 2014 17:39:48 -0400 (EDT)
Date: Thu, 16 Oct 2014 17:39:48 -0400 (EDT)
From: Rick Macklem <rmacklem@uoguelph.ca>
To: araujo@FreeBSD.org
Message-ID: <997140144.720996.1413495588502.JavaMail.root@uoguelph.ca>
In-Reply-To: <CAOfEmZjf-rLD6uYw-qCq7CiSNEDW4z6C_iF4zJT2p8_dRAFijg@mail.gmail.com>
Subject: Re: [PATCH] disable nfsd (NFSv4) nobody/nogroup check
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.17.91.209]
X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926)
Cc: freebsd-fs@freebsd.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Oct 2014 21:39:50 -0000

Marcelo Araujo wrote:
> 
> 
> 
> 
> 
> 2014-10-16 10:42 GMT+08:00 Marcelo Araujo < araujobsdport@gmail.com >
> :
> 
> 
> 
> 
> 
> 
> 
> 2014-10-16 7:46 GMT+08:00 Rick Macklem < rmacklem@uoguelph.ca > :
> 
> 
> Marcelo Araujo wrote:
> > 
> > Hello Ronald and Blot,
> > 
> > 
> > 
> > Here is the patch with a small rework. I consider Ronaldo's
> > comments
> > as well as I just change a bit the code style.
> > 
> > 
> > If you guys agree with the patch, I will commit it today.
> > 
> Looks fine to me.
> 
> 
> 
> Thanks Rick! Committed; I will do the MFC after two weeks if you have
> no objections.
> 
> 
> https://svnweb.freebsd.org/base?view=revision&revision=273159
> 
> 
> 
> 
> > 
> > Note: About the disable_utf8 that Rick has mention, I will rework
> > that part later to make it as enable_utf8 instead of disable_utf8.
> > 
> If you do change this one, try to include something in the
> description
> string w.r.t. RFC-3530 requires it to be enabled.
> 
> Thanks, rick
> 
> 
> 
> 
> 
> 
> Rick, here is a patch that renames the disable_utf8 to enable_utf8
> and as per your request, I have changed the description of the
> sysctl(8) as well.
> Let me know if the change looks good for you as well as the
> description.
> 
Looks fine to me, rick
ps: I would suggest not MFC'ng this one, since I think it would be
    a POLA violation to have the sysctl name change.

> 
> 
> 
> 
> 
> 
> 
> 
> 
> Ouch, I forgot to attach the patch, spotted by kevlo@ via Skype :_)
> 
> 
> 
> 
> Best Regards,
> 
> --
> 
> 
> 
> 
> --
> Marcelo Araujo            (__) araujo@FreeBSD.org \\\'',)
> http://www.FreeBSD.org \/  \ ^
> Power To Server.         .\. /_)