From owner-cvs-all@FreeBSD.ORG Mon May 30 10:41:11 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 035C816A41C; Mon, 30 May 2005 10:41:11 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 490AB43D55; Mon, 30 May 2005 10:41:09 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j4UAf8HZ011372; Mon, 30 May 2005 13:41:08 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 68829-15; Mon, 30 May 2005 13:41:07 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j4UAf79F011369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 May 2005 13:41:07 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j4UAfV1t055019; Mon, 30 May 2005 13:41:31 +0300 (EEST) (envelope-from ru) Date: Mon, 30 May 2005 13:41:31 +0300 From: Ruslan Ermilov To: Maxim Sobolev Message-ID: <20050530104131.GB54585@ip.net.ua> References: <200505292105.j4TL5w32038570@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline In-Reply-To: <200505292105.j4TL5w32038570@repoman.freebsd.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libstand Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2005 10:41:11 -0000 --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote: > sobomax 2005-05-29 21:05:58 UTC >=20 > FreeBSD src repository >=20 > Modified files: > lib/libstand Makefile=20 > Log: > Add missed ${.CURDIR}/../../contrib/bzip2 into include search path, oth= erwise > old version of bzlib.h can be picked up from the /usr/include. > =20 > Revision Changes Path > 1.51 +1 -1 src/lib/libstand/Makefile >=20 Changes like this, while harmless, unnecessarily pollute makefiles. During buildworld we first install new headers then build new libraries then the rest. When doing standalone compiles, the same procedure should generally be followed. (Otherwise, you'd end up changing every utility's makefile that uses libstand to add this -I to CFLAGS.) I have only problem with the above change: it has a wrong attribution in the commit log. The correct commit log would be: "aid in lazy standalone builds by always picking up a fresh copy of bzlib.h from sources". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFCmu3aqRfpzJluFF4RAnwXAJ43zyuFgq0JQpv1e68NpBV2Lb7zygCdGhuD Q8qdjHf0f/Y7EztpFbYEXEY= =gzRP -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6--