From owner-svn-src-user@FreeBSD.ORG Thu Mar 11 20:32:29 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47166106566C; Thu, 11 Mar 2010 20:32:29 +0000 (UTC) (envelope-from jmallett@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 37F498FC08; Thu, 11 Mar 2010 20:32:29 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o2BKWT4J089156; Thu, 11 Mar 2010 20:32:29 GMT (envelope-from jmallett@svn.freebsd.org) Received: (from jmallett@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o2BKWTrG089154; Thu, 11 Mar 2010 20:32:29 GMT (envelope-from jmallett@svn.freebsd.org) Message-Id: <201003112032.o2BKWTrG089154@svn.freebsd.org> From: Juli Mallett Date: Thu, 11 Mar 2010 20:32:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r205025 - user/jmallett/octeon/sys/mips/mips X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 20:32:29 -0000 Author: jmallett Date: Thu Mar 11 20:32:28 2010 New Revision: 205025 URL: http://svn.freebsd.org/changeset/base/205025 Log: I don't know that a critical section is required here, but if it is we really don't want to get interrupted between reading the counter and calculating the ticks. Modified: user/jmallett/octeon/sys/mips/mips/tick.c Modified: user/jmallett/octeon/sys/mips/mips/tick.c ============================================================================== --- user/jmallett/octeon/sys/mips/mips/tick.c Thu Mar 11 17:56:46 2010 (r205024) +++ user/jmallett/octeon/sys/mips/mips/tick.c Thu Mar 11 20:32:28 2010 (r205025) @@ -117,8 +117,8 @@ tick_ticker(void) * from the time counter, so I'm not sure why all these hoops * are even necessary. */ - ticktock = mips_rd_count(); critical_enter(); + ticktock = mips_rd_count(); if (ticktock < counter_lower_last) counter_upper++; counter_lower_last = ticktock;