From owner-freebsd-perl@FreeBSD.ORG  Tue Apr 23 08:35:49 2013
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: perl@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 5B7B0DBF
 for <perl@freebsd.org>; Tue, 23 Apr 2013 08:35:49 +0000 (UTC)
 (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 27A141FE8
 for <perl@freebsd.org>; Tue, 23 Apr 2013 08:35:47 +0000 (UTC)
Received: from ds4.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id E4D968861
 for <perl@freebsd.org>; Tue, 23 Apr 2013 08:35:46 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
 id BBD069856; Tue, 23 Apr 2013 10:35:46 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: perl@freebsd.org
Subject: [patch] net/p5-RPC-XML loop detection bug
Date: Tue, 23 Apr 2013 10:35:45 +0200
Message-ID: <86txmxskym.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: maintainer of a number of perl-related ports
 <freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2013 08:35:49 -0000

The hash serializing code in RPC::XML tries to detect and prevent loops,
but what it actually does is detect and prevent repetitions.  The
easiest way to reproduce this is to try to serialize a hash containing
two DateTime objects representing the same time, because DateTime
objects are singletons.

I've submitted a patch upstream and received a positive response, but it
hasn't appeared on github and there is no sign of a new release.  I'd
like to commit the following patch to net/p5-RPC-XML:

Index: net/p5-RPC-XML/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- net/p5-RPC-XML/Makefile	(revision 316245)
+++ net/p5-RPC-XML/Makefile	(working copy)
@@ -7,6 +7,7 @@
=20
 PORTNAME=3D	RPC-XML
 PORTVERSION=3D	0.77
+PORTREVISION=3D	1
 CATEGORIES=3D	net www perl5
 MASTER_SITES=3D	CPAN
 PKGNAMEPREFIX=3D	p5-
Index: net/p5-RPC-XML/files/patch-lib-RPC-XML.pm
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- net/p5-RPC-XML/files/patch-lib-RPC-XML.pm	(revision 0)
+++ net/p5-RPC-XML/files/patch-lib-RPC-XML.pm	(working copy)
@@ -0,0 +1,10 @@
+--- lib/RPC/XML.pm.orig	2011-08-22 11:29:30.000000000 +0200
++++ lib/RPC/XML.pm	2013-04-23 10:28:19.780990362 +0200
+@@ -258,6 +258,7 @@
+                     $type =3D reftype $_;
+                     die "Un-convertable reference: $type, cannot use\n";
+                 }
++                $seenrefs->{$_}--;
+             }
+             # You have to check ints first, because they match the
+             # next pattern (for doubles) too

Property changes on: net/p5-RPC-XML/files/patch-lib-RPC-XML.pm
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no